Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 #54

Open
limburgher opened this issue Aug 8, 2019 · 14 comments
Open

Python 3 #54

limburgher opened this issue Aug 8, 2019 · 14 comments

Comments

@limburgher
Copy link

Python 2 is going away next year, are there plans to move to Python 3?

@nagappan
Copy link
Member

nagappan commented Aug 8, 2019

I was thinking someone ported it to support Python3, but really not, I could not find any pull request or issues, seems I have to find some time to work on it

@limburgher
Copy link
Author

Thank you!

@nullr0ute
Copy link

It also depends on a bunch of long obsolete GNOME bindings which will also be going away because they don't support python3 such as gnome-python2* pygtk2-libglade, pyorbit, libbonobo* libgnome* and should be moved to GObject introspection based bindings

@kartikm
Copy link

kartikm commented Oct 22, 2019

@schuellerf
Copy link
Contributor

Please check if #58 solves your problem

@limburgher
Copy link
Author

It would seem not:

[gwyn@fedora64 ldtp]$ ldtp
Traceback (most recent call last):
File "/usr/bin/ldtp", line 23, in
import ldtpd
File "/usr/lib/python3.8/site-packages/ldtpd/init.py", line 38, in
from xmlrpc_daemon import XMLRPCLdtpd
ModuleNotFoundError: No module named 'xmlrpc_daemon'

@schuellerf
Copy link
Contributor

Please try again - I think you didn't try my python3 branch?!
there should be a "dot" just before the xmlrpc_daemon packge:
https://github.com/schuellerf/ldtp2/blob/python3/ldtpd/__init__.py#L38
this fixed the import for me

@limburgher
Copy link
Author

That branch seems to be based on 3.4.1; we're already on 3.5.0.

@schuellerf
Copy link
Contributor

schuellerf commented Jun 1, 2020

I think my branch is up to date with master and git describe also seems to be fine

# git describe --tags
LDTP_3.5.0-136-gee22cd1

@limburgher why to you think so?

@limburgher
Copy link
Author

ls ~/rpmbuild/BUILDROOT/ldtp-3.5.0-15.fc33.x86_64/usr/lib/python3.9/site-packages/
ldtp ldtp-3.4.1-py3.9.egg-info ldtpd ldtpme ldtputils ooldtp
[gwyn@fedora64 ldtp2]$ grep version= setup.py
version="3.4.1",

@Werni2A
Copy link

Werni2A commented Jun 9, 2020

I'm not a Python expert but maybe there is some kind of misunderstanding. I took a look at the PR and it looks like the version string was changed from "3.5.1" to "3.4.1" in the setup.py maybe by mistake.
@limburgher This would explain the result from your grep

@schuellerf
Copy link
Contributor

Thanks @Werni2A for clarifying - I just wanted to highlight that the API might be incompatible.
@limburgher can you check if it works now? or just change the version to 3.5.1 in setup.py as it's not relevant for a test of basic functionality of my branch I think

@limburgher
Copy link
Author

It's reporting 3.6.0 now. If I update my RPM spec to reflect that, and include the new ldtpme bits, I can build it. What's a fast test I can run on a progam I'm likely to have installed? :)

@schuellerf
Copy link
Contributor

It's reporting 3.6.0 now. If I update my RPM spec to reflect that, and include the new ldtpme bits, I can build it. What's a fast test I can run on a progam I'm likely to have installed? :)

I only use my xfce-test containers for ldtp...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants