Windows: Avoid accidentally using GNU link.exe for linking #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilsonator
approved these changes
Aug 4, 2024
This happens in an environment where MSVC was set up first (so env var VSINSTALLDIR defined), and later prepending a dir such as `C:\Program Files\Git\usr\bin` to PATH, so that the first link.exe on PATH isn't the Microsoft one.
kinke
force-pushed
the
msvc_resolve_tool
branch
from
496efeb
to
16cd1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens in an environment where MSVC was set up first (so env var
VSINSTALLDIRdefined), and later prepending a dir such asC:\Program Files\Git\usr\binto PATH, so that the firstlink.exeon PATH isn't the Microsoft one.