Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druntime: adds ASM language to cmake project() directive #4715

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Jul 30, 2024

Sometimes CMake silently(!) ignores .S (asm) files if ASM isn't mentioned in the project directive. I ran into it during build my custom non-posix && non-windows target. It was very hard to understand what is happens

Similar issue: https://stackoverflow.com/questions/23452089/why-is-cmake-ignoring-assembly-files-when-building-static-library/67902603#67902603

@denizzzka denizzzka marked this pull request as ready for review July 30, 2024 15:10
@JohanEngelen JohanEngelen enabled auto-merge (squash) July 30, 2024 15:20
@JohanEngelen
Copy link
Member

thanks!

@JohanEngelen JohanEngelen merged commit 48c1dff into ldc-developers:master Jul 30, 2024
20 checks passed
kinke pushed a commit to kinke/ldc that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants