Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shell configurable in CI scripts, to later enable re-using same … #4700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohanEngelen
Copy link
Member

…scripts for Alpine musl CI.

@kinke
Copy link
Member

kinke commented Jul 12, 2024

God is this ugly. How about simply changing the shell once for the musl job, as already proposed earlier?

@kinke
Copy link
Member

kinke commented Jul 12, 2024

Seeing that there have been a bunch of explicit bash already (for Windows), an alternative might be simply using an Alpine Docker image, instead of that chroot-thing or whatever it is in detail that the GHA action uses.

@JohanEngelen
Copy link
Member Author

God is this ugly. How about simply changing the shell once for the musl job, as already proposed earlier?

how would that work? Because everywhere it is explicitly mentioned, so overrides the default.

@kinke
Copy link
Member

kinke commented Jul 13, 2024

We can default the Windows job shell to bash too, and explicitly select cmd for those Windows-specific steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants