-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures on linux aarch64 #4613
Comments
This is a subset of Lines 56 to 64 in e170ca5
IIRC, the math issues boil down to 2 problems - one being slightly incomplete 128-bit quadruple-precision The sporadic |
Thanks for the new links, I should have looked a bit harder before opening the issues.
The One last thing, should |
FYI it is this unittest in core.thread.fiber that is causing trouble on AArch64 (both macOS, and linux-musl): ldc/runtime/druntime/src/core/thread/fiber.d Lines 2303 to 2350 in 40ad5f7
version(AArch64)
return; fixes things for me. (both on macOS and linux musl) |
Some tests fail on my Raspberry Pi 4 running Gentoo.
The first issue is with
std.internal.math.gammafunction
:This is because https://github.com/dlang/phobos/blob/14b23633b762cfd7b03614dca4c6b0cafa1016e5/std/internal/math/gammafunction.d#L396 contains
real.mant_dig
which on my PC is64
but on the PI it is113
. I guess the solution is to change the value to a constant and not have it be dependent onreal
since this type varies by platform, but I'm not 100% sure what to do.Secondly
std.internal.exponential
:Which is weird since only the release builds fail. I've tried to minimize the test case to:
The problem with this one is that the assert fails on different lines based on optimizations:
and
It's possible that bad code is generated. Another thing, I don't know how helpful, is that uncommenting the
//assert
line makes the optimized build not go into the if (and fail normally).The last problem I had was with
core.thread.fiber
:The release builds hang. Running the tests directly I get:
Enabling
ChekFiberMigration
doesn't solve it:Better, I'm also getting segmentation faults sometime:
I have no idea how to approach fixing this one.
The text was updated successfully, but these errors were encountered: