From 0ddc65ce356ac8036fc9c9e8b6dad9378ebddde5 Mon Sep 17 00:00:00 2001
From: Martin Kinkelin <mkinkelin@symmetryinvestments.com>
Date: Sun, 31 Mar 2024 04:05:44 +0200
Subject: [PATCH] [nope, ldc2-unittest hangs]

---
 .github/workflows/main.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index cc0689f9c6..84739adbd4 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -42,6 +42,7 @@ jobs:
             bootstrap_cmake_flags: >-
               -DBUILD_LTO_LIBS=ON
               -DD_COMPILER_FLAGS=-gcc=/usr/bin/c++
+            # /usr/local/lib/libzstd.dylib detected/used during LLVM build => `-lzstd` part of `llvm-config --system-libs`
               -DCMAKE_EXE_LINKER_FLAGS=-L/usr/local/lib
             # https://github.com/ldc-developers/ldc/issues/4462:
             # When using LTO, we need to explicitly export ~all symbols for plugin support via `ld64 -exported_symbol '__*'`.
@@ -59,13 +60,15 @@ jobs:
             bootstrap_cmake_flags: >-
               -DBUILD_LTO_LIBS=ON
               -DD_COMPILER_FLAGS=-gcc=/usr/bin/c++
+            # seems like an LLVM bug - no libzstd detected/used during LLVM build, yet part of --system-libs apparently
               -DCMAKE_EXE_LINKER_FLAGS=-L/opt/homebrew/opt/zstd/lib
             extra_cmake_flags: >-
               -DBUILD_LTO_LIBS=ON
               -DD_COMPILER_FLAGS="-gcc=/usr/bin/c++ -O -flto=full -defaultlib=phobos2-ldc-lto,druntime-ldc-lto -L-exported_symbol '-L__*' -L-w"
               -DCMAKE_EXE_LINKER_FLAGS=-L/opt/homebrew/opt/zstd/lib
+            # FIXME: 'LLVM ERROR: Unsupported stack probing method' when extending LTO to C++ parts and trying to link ldc2
             # -DEXTRA_CXXFLAGS=-flto=full
-            with_pgo: true
+            with_pgo: false # FIXME: ldc2-unittest hangs at runtime (at least sometimes?) with LTO+PGO
 
           - job_name: Windows x64
             os: windows-2022