Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asr->python] add complex visitors #2581

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[asr->python] add complex visitors #2581

wants to merge 3 commits into from

Conversation

khushi-411
Copy link
Contributor

No description provided.

@Shaikh-Ubaid
Copy link
Collaborator

@khushi-411 Can you add tests for this?

@khushi-411 khushi-411 changed the title [asr->python] add complex visitors [asr->python] add complex, string{item, section} visitors Mar 7, 2024
@Shaikh-Ubaid
Copy link
Collaborator

I would suggest focusing on one particular support in this PR. For example, either complex visitors or string visitors. And then add good tests for it. We can support the other visitors (for example string visitors) in a separate PR.

@khushi-411 khushi-411 changed the title [asr->python] add complex, string{item, section} visitors [asr->python] add complex visitors Mar 8, 2024
@Shaikh-Ubaid
Copy link
Collaborator

Good. Now we need to add tests that test each of the implemented visitor.

@Thirumalai-Shaktivel
Copy link
Collaborator

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushi-411 @Shaikh-Ubaid @Thirumalai-Shaktivel