Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server.app for FRI 1.16 #30

Open
pala5 opened this issue Jun 11, 2024 · 5 comments
Open

Server.app for FRI 1.16 #30

pala5 opened this issue Jun 11, 2024 · 5 comments

Comments

@pala5
Copy link

pala5 commented Jun 11, 2024

Could you please provide the equivalent Server.app version for FRI 1.16?
Thank you very much.

@mhubii
Copy link
Member

mhubii commented Jun 11, 2024

Hi @pala5, sorry I personally don't have access. The app for 1.15 should, however run fine: https://github.com/lbr-stack/fri/blob/ros2-fri-1.15/server_app/LBRServer.java

if you could check and contribute, that would be awesome!

Alternatively, @BoWangFromMars uses FRI 1.16. Maybe he can help out.

@pala5
Copy link
Author

pala5 commented Jun 11, 2024

Thanks @mhubii. True, I was already using the 1.15's app. I'll test it further tomorrow. I'll let you know.

@pala5
Copy link
Author

pala5 commented Jun 12, 2024

Hi @mhubii, good news from my side. As you have said, Server.app for FRI 1.15 works well. Could it be nice to note it on the README, or maybe even better, rename the branch as ros2-fri-1.15-16. It is just a suggestion.
Thank you!

@pala5 pala5 closed this as completed Jun 12, 2024
@mhubii
Copy link
Member

mhubii commented Jun 13, 2024

hi @pala5 thank you for coming back. Let's keep this issue open for now. As you said, this isn't properly documented, nor is the server application at the right location.

If you would be interested in creating a pull request that moves the server_app folder from ros2-fri-1.15 branch (legacy branch) to fri-1.16 branch, let me know! Happy to review and merge

@mhubii mhubii reopened this Jun 13, 2024
@pala5
Copy link
Author

pala5 commented Jun 14, 2024

hi @mhubii I would like to do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants