diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a350d76..86b9cee 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,7 +11,9 @@ jobs: os: [ ubuntu-latest, macos-latest, windows-latest ] fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 + # https://github.com/nodejs/node-gyp/issues/2869 + - run: python3 -m pip install setuptools - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v3 with: @@ -40,7 +42,7 @@ jobs: strategy: matrix: node-version: [ 16, 18, 20 ] - container: node:${{ matrix.node-version }}-alpine3.18 + container: node:${{ matrix.node-version }}-alpine steps: - uses: actions/checkout@v3 - name: install build deps diff --git a/src/isolate/inspector.cc b/src/isolate/inspector.cc index c3b5394..c71a090 100644 --- a/src/isolate/inspector.cc +++ b/src/isolate/inspector.cc @@ -81,7 +81,7 @@ auto InspectorAgent::ConnectSession(InspectorSession& session) -> unique_ptrinsert(&session); #if V8_AT_LEAST(10, 3, 118) return inspector->connect(1, &session, StringView(), v8_inspector::V8Inspector::ClientTrustLevel::kFullyTrusted); -#elif +#else return inspector->connect(1, &session, StringView()); #endif }