Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken "rate limiting" link #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cwaldren-ld
Copy link

@cwaldren-ld cwaldren-ld commented Jan 16, 2024

Updates dead link in README.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review January 16, 2024 19:18
@cwaldren-ld
Copy link
Author

I don't know how our generated docs work - do those come from this repo? The link works there, but not on the Github README.

Perhaps merging this would then break the generated docs?

Copy link

@lucywyman lucywyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is actually generated from this doc I believe: https://github.com/launchdarkly/gonfalon/blob/main/apidocs/content/overview.md?plain=1#L243 Can you update it there?

@lucywyman
Copy link

I don't know how our generated docs work - do those come from this repo? The link works there, but not on the Github README.

Perhaps merging this would then break the generated docs?

Oh dang, I thought that this would still work for the generated docs but it does not :( Hmm....

@cwaldren-ld
Copy link
Author

Another idea: we could just delete the link, since the linked section is like 1 inch below the table. Unsatisfying though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants