Fix: spawn task when opening new connection in acquire. #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Sep 20, 2024
There was a problem hiding this comment.
This is a good start, but strictly speaking it doesn't fix #2848 because it doesn't retry the idle queue once it decides to connect. That's the problem there.
Once it passes its permit to the spawned task, it could try to acquire another and race to see which completes first. Since the connection is happening in a background task, the attempt won't be wasted, as it'll just return to the idle queue.
|
Now the pool tries to get an idle connection while opening a new connection. It has a backoff mechanism (taken from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #3513,#3315,#3132,#2848
Ive read through the issues and I think this is the solution like proposed in #2848. However I don't think this is done yet. Should the connect_timeout be a part of the public api? Is 30 seconds a good default?