Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instruction builder #7

Open
laudominik opened this issue Sep 17, 2023 · 2 comments
Open

Improve instruction builder #7

laudominik opened this issue Sep 17, 2023 · 2 comments

Comments

@laudominik
Copy link
Owner

laudominik commented Sep 17, 2023 •
edited
Loading

Some ideas for architectural improvements of instruction builder:

  • pass cpu reference as property to instruction
  • have a function in InstructionIfc to compute the address of operation (it will be used a lot) (eip-sizeof(instruction))
@laudominik laudominik changed the title Refactor instruction builder Improve instruction builder Sep 17, 2023
laudominik added a commit that referenced this issue Sep 17, 2023
@laudominik
#7 improve instruction builder
9d64fa6
@laudominik
Copy link
Owner Author

Let's keep it open for further improvement ideas

@laudominik
Copy link
Owner Author

We could change InstructionData to be not in specialization, but as a separate class to call in InstructionIfc::fetch() method (not all instructions use it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laudominik