AnnotatedCodeGeneratorFactory writes namespace and using statements in wrong order

[davidwincent]

Expected behaviour to put using statements first in generated class file

[davidwincent]

Created public gist: https://gist.github.com/davidwincent/69a8d8de2416ba674b44
Default.cs is the generated class file.

[davidwincent]

Turns out that it works as long as you don't use the word Umbraco in namespace. Perhaps solution suggested in #6 solves the same problem?

[lars-erik]

I don't agree that it's wrong, but I can agree it's a matter of taste. :)
However, I don't see that the way generated files order it's using statements have any impact on the quality of the code. You're free to put them elsewhere in the partials.
For the record, I usually have them first myself, but since it clashes with the Umbraco part, I've put them inside for now. Don't think I want to change namespace now.

[davidwincent]

Ah, OK! I agree.

What would I need to do to change the formatting?
Write a custom CodeGenerator?

[lars-erik]

Sorry, I've been confusing things here.
I never hit this problem since my projects always have namespace CustomerName.Web.
Is there really a good reason to include Umbraco in your namespace?
You can also configure codegen to use another namespace for the generated classes, then you're home free.

[davidwincent]

No specific reason to include Umbraco in the namespace. I found the problem by accident when I was testing in that namespace.
Having said that it still looks odd to me having the using statements wrapped inside the namespace declaration. I usually put them in the beginning of the file. 🙏

[lars-erik]

I had to put them inside due to some other namespace conflicts. :D

[davidwincent]

No problem. Then I know there is a reason. I think this project could be the missing link in my past U7 projects. Nicely done!

[lars-erik]

:)