Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cinch_add_application_directory and cinch_target_link_libraries #95

Open
junghans opened this issue Jun 5, 2017 · 4 comments
Open

Remove cinch_add_application_directory and cinch_target_link_libraries #95

junghans opened this issue Jun 5, 2017 · 4 comments
Assignees
@charest
Labels
enhancement

Comments

@junghans
Copy link
Member

junghans commented Jun 5, 2017

After the refactor cinch_add_application_directory and cinch_target_link_libraries don't do anything anymore, so we should mark them as deprecated (message(WARNING ...)) and remove them in the next version of cinch.
@charest
Copy link
Contributor

charest commented Jun 5, 2017

@junghans I left them there because they print out a nice message. So they still do something!

@junghans
Copy link
Member Author

junghans commented Jun 5, 2017

@tuxfan : Do we need this message?

@junghans
Copy link
Member Author

junghans commented Jun 5, 2017

I would prefer using plain cmake functions.

@charest
Copy link
Contributor

charest commented Jun 5, 2017

We probably don't, I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charest charest

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junghans @charest