Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache result #28

Open
uyab opened this issue Aug 24, 2018 · 9 comments
Open

Cache result #28

uyab opened this issue Aug 24, 2018 · 9 comments

Comments

@uyab
Copy link
Contributor

uyab commented Aug 24, 2018

No description provided.

@rizkyarlin
Copy link
Contributor

ada informasi tambahan soal ini mas?

@uyab
Copy link
Contributor Author

uyab commented Sep 21, 2019

Ini terkait semua fungsi di IndonesiaService, bisa ditambahkan mekanisme caching karena data wilayah ini kan jarang sekali berubah.

@rizkyarlin
Copy link
Contributor

Oke mas, kalau gak ada yg buat PR-nya, nanti aku yg coba

@uyab
Copy link
Contributor Author

uyab commented Sep 21, 2019

Sip, beberapa kriteria dari saya:

  1. Cache ini harus configurable, bisa di enable/disable lewat config
  2. Ada tagging khusus untuk semua cache dari IndonesiaService, jadi kalau mau clear cache khusus untuk data Indonesia cukup mudah.
  3. Otomatis detect ketika model berubah, cache diinvalidate.

@rizkyarlin
Copy link
Contributor

What cache driver do you prefer?

@uyab
Copy link
Contributor Author

uyab commented Sep 21, 2019

Pakai Cache bawaan Laravel, driver bisa configurable.

@rizkyarlin
Copy link
Contributor

Oke... Nanti kalau udah kosong, sy coba. Tp kalau ada yg lain yg mau duluan PR, monggo...

@uyab
Copy link
Contributor Author

uyab commented Nov 13, 2019

@rizkyarlin ada update kah?

@rizkyarlin
Copy link
Contributor

Maaf, lg swamped banget nih, mas bayu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants