From d3fbab75567b798abbde7587e76e6e521c524049 Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Wed, 24 Jul 2024 09:17:14 +0800 Subject: [PATCH] wip Signed-off-by: Mior Muhammad Zaki --- lang/vendor/nova/en.json | 1 + tests/Browser/ActionFieldTest.php | 8 ++--- tests/Browser/ActionModalAbandonmentTest.php | 4 +-- tests/Browser/AttachDuplicationTest.php | 6 ++-- tests/Browser/AttachPolymorphicTest.php | 20 ++++++------- .../AttachResourceFormAbandonmentTest.php | 4 ++- tests/Browser/AttachSoftDeletingTest.php | 16 +++++----- tests/Browser/AttachTest.php | 12 ++++---- tests/Browser/AuthenticatesUserTest.php | 20 ++++++------- .../CreateResourceFormAbandonmentTest.php | 4 ++- tests/Browser/CreateTest.php | 10 +++---- tests/Browser/CreateWithBelongsToTest.php | 14 ++++----- .../Browser/CreateWithHasManyThroughTest.php | 2 +- .../CreateWithInlineRelationButtonTest.php | 30 +++++++++---------- tests/Browser/CreateWithPolymorphicTest.php | 2 +- .../CreateWithSoftDeletingMorphToTest.php | 2 +- tests/Browser/CustomAuthenticatesUserTest.php | 12 ++++---- tests/Browser/DashboardTest.php | 6 ++-- tests/Browser/DependentActionFieldTest.php | 4 +-- tests/Browser/DependentBelongsToFieldTest.php | 2 +- .../DependentBelongsToManyFieldTest.php | 2 +- .../DependentBooleanGroupFieldTest.php | 2 +- .../Browser/DependentMultiSelectFieldTest.php | 4 +-- tests/Browser/DetailActionTest.php | 2 +- tests/Browser/FileAttachTest.php | 2 +- .../FilterableBelongsToManyFieldTest.php | 10 +++---- tests/Browser/FilterableFieldTest.php | 4 +-- tests/Browser/FormButtonTest.php | 4 +-- tests/Browser/GlobalSearchTest.php | 6 ++-- tests/Browser/HasOneAuthorizationTest.php | 2 +- tests/Browser/ImpersonatesUserTest.php | 8 ++--- tests/Browser/IndexActionTest.php | 2 +- tests/Browser/IndexAuthorizationTest.php | 4 +-- tests/Browser/IndexPreviewTest.php | 2 +- tests/Browser/IndexSearchTest.php | 2 +- tests/Browser/IndexTest.php | 4 +-- tests/Browser/InlineActionDropdownTest.php | 2 +- ...lineCreateResourceModalAbandonmentTest.php | 2 ++ tests/Browser/LensActionTest.php | 4 +-- tests/Browser/LensTest.php | 2 +- tests/Browser/MainMenuTest.php | 12 ++++---- tests/Browser/ModalTest.php | 8 ++--- tests/Browser/NotificationTest.php | 8 ++--- tests/Browser/PaginationTest.php | 4 +-- tests/Browser/PivotFileAttachTest.php | 4 +-- tests/Browser/RemoveAttachedTest.php | 2 +- tests/Browser/RepeaterFieldTest.php | 6 ++-- tests/Browser/ReplicateTest.php | 12 ++++---- tests/Browser/ResourceClickActionTest.php | 12 ++++---- tests/Browser/ResourceTableSelectionTest.php | 12 ++++---- tests/Browser/TagFieldTest.php | 2 +- tests/Browser/ToolAuthorizationTest.php | 4 +-- ...ateAttachedResourceFormAbandonmentTest.php | 4 ++- tests/Browser/UpdateAttachedTest.php | 16 +++++----- .../UpdateResourceFormAbandonmentTest.php | 6 ++-- tests/Browser/UpdateTest.php | 12 ++++---- tests/Browser/UpdateWithBelongsToTest.php | 8 ++--- tests/Browser/UpdateWithMorphToTest.php | 14 ++++----- .../VisitPreviousPageRedirectionTest.php | 4 +-- 59 files changed, 205 insertions(+), 194 deletions(-) diff --git a/lang/vendor/nova/en.json b/lang/vendor/nova/en.json index 55f4a7cf..7e37f00f 100644 --- a/lang/vendor/nova/en.json +++ b/lang/vendor/nova/en.json @@ -469,6 +469,7 @@ "Copy to clipboard": "Copy to clipboard", "Are you sure you want to delete this notification?": "Are you sure you want to delete this notification?", "The image could not be loaded": "The image could not be loaded", + "Export As CSV": "Export As CSV", "Filename": "Filename", "Type": "Type", "CSV (.csv)": "CSV (.csv)", diff --git a/tests/Browser/ActionFieldTest.php b/tests/Browser/ActionFieldTest.php index 369ac011..db311528 100755 --- a/tests/Browser/ActionFieldTest.php +++ b/tests/Browser/ActionFieldTest.php @@ -63,7 +63,7 @@ public function test_actions_modal_shouldnt_closed_when_user_using_shortcut() ->clickCheckboxForId(1) ->selectAction('update-pivot-notes', function ($browser) { $browser->elsewhere('', function ($browser) { - $browser->whenAvailable(new ConfirmActionModalComponent(), function ($browser) { + $browser->whenAvailable(new ConfirmActionModalComponent, function ($browser) { $browser->assertScript('Nova.useShortcuts', false) ->assertSee('Provide a description for notes.'); })->keys('', ['e']); @@ -89,7 +89,7 @@ public function test_actions_can_be_validated() $browser->waitForTable() ->clickCheckboxForId(1) ->runAction('update-required-pivot-notes') - ->elsewhere(new ConfirmActionModalComponent(), function ($browser) { + ->elsewhere(new ConfirmActionModalComponent, function ($browser) { $browser->assertSee(__('validation.required', ['attribute' => 'Notes'])); }); }); @@ -137,13 +137,13 @@ public function test_actions_cant_be_executed_when_not_authorized_to_run() ->within(new IndexComponent('users'), function (Browser $browser) { $browser->waitForTable() ->openControlSelectorById(1) - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function (Browser $browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function (Browser $browser) { $browser->waitFor('@1-preview-button') ->assertMissing('@1-inline-actions'); }) ->closeCurrentDropdown() ->openControlSelectorById(2) - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function (Browser $browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function (Browser $browser) { $browser->assertSee('Mark As Inactive'); }); }); diff --git a/tests/Browser/ActionModalAbandonmentTest.php b/tests/Browser/ActionModalAbandonmentTest.php index 9e1b06e7..ed684a17 100644 --- a/tests/Browser/ActionModalAbandonmentTest.php +++ b/tests/Browser/ActionModalAbandonmentTest.php @@ -25,7 +25,7 @@ public function test_modal_shows_exit_warning_dialog_if_form_has_changes() ->clickCheckboxForId(1) ->selectAction('update-required-pivot-notes', function ($browser) { $browser->elsewhere('', function ($browser) { - $browser->whenAvailable(new ConfirmActionModalComponent(), function ($browser) { + $browser->whenAvailable(new ConfirmActionModalComponent, function ($browser) { $browser->keys('@notes', 'Custom Notes', '{tab}'); }) ->assertPresentModal() @@ -56,7 +56,7 @@ public function test_it_doesnt_show_exit_warning_if_modal_has_changes_when_click $browser->waitForTable() ->clickCheckboxForId(1) ->selectAction('update-required-pivot-notes', function ($browser) { - $browser->elsewhereWhenAvailable(new ConfirmActionModalComponent(), function ($browser) { + $browser->elsewhereWhenAvailable(new ConfirmActionModalComponent, function ($browser) { $browser->type('@notes', 'Custom Notes')->cancel(); }) ->pause(100) diff --git a/tests/Browser/AttachDuplicationTest.php b/tests/Browser/AttachDuplicationTest.php index f036f7b2..c9f01b5c 100644 --- a/tests/Browser/AttachDuplicationTest.php +++ b/tests/Browser/AttachDuplicationTest.php @@ -23,7 +23,7 @@ public function test_it_cant_attach_different_unique_relation() $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'roles')) - ->within(new FormComponent(), function ($browser) use ($role) { + ->within(new FormComponent, function ($browser) use ($role) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -60,7 +60,7 @@ public function test_it_can_attach_different_relation_groups() $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'books', 'giftBooks')) ->assertSeeIn('h1', 'Attach Book') - ->within(new FormComponent(), function ($browser) use ($now) { + ->within(new FormComponent, function ($browser) use ($now) { $browser->selectAttachable(4) ->type('@price', '39') ->typeOnDateTimeLocal('input[dusk="purchased_at"]', $now); @@ -101,7 +101,7 @@ public function test_it_can_attach_duplicate_relations_with_different_pivot() $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'books', 'personalBooks')) ->assertSeeIn('h1', 'Attach Book') - ->within(new FormComponent(), function ($browser) use ($now) { + ->within(new FormComponent, function ($browser) use ($now) { $browser->selectAttachable(4) ->type('@price', '34') ->typeOnDateTimeLocal('input[dusk="purchased_at"]', $now); diff --git a/tests/Browser/AttachPolymorphicTest.php b/tests/Browser/AttachPolymorphicTest.php index d9ce4881..9f4e77e4 100755 --- a/tests/Browser/AttachPolymorphicTest.php +++ b/tests/Browser/AttachPolymorphicTest.php @@ -29,13 +29,13 @@ public function test_non_searchable_resource_can_be_attached() ->click('@attach-button'); }) ->on(Attach::morphToMany('posts', $post->id, 'tags')) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink("User Post Details: {$post->id}") ->assertCurrentPageTitle('Attach Tag'); }) - ->within(new FormComponent(), function ($browser) use ($tag) { + ->within(new FormComponent, function ($browser) use ($tag) { $browser->searchFirstRelation('tags', $tag->id); }) ->create() @@ -64,12 +64,12 @@ public function test_searchable_resource_can_be_attached() ->click('@attach-button'); }) ->on(Attach::morphToMany('posts', $post->id, 'tags')) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink("User Post Details: {$post->id}") ->assertCurrentPageTitle('Attach Tag'); }) - ->within(new FormComponent(), function ($browser) use ($tag) { + ->within(new FormComponent, function ($browser) use ($tag) { $browser->searchFirstRelation('tags', $tag->id); }) ->create() @@ -93,12 +93,12 @@ public function test_fields_on_intermediate_table_should_be_stored() $browser->loginAs(1) ->visit(Attach::morphToMany('posts', $post->id, 'tags')) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink("User Post Details: {$post->id}") ->assertCurrentPageTitle('Attach Tag'); }) - ->within(new FormComponent(), function ($browser) use ($tag) { + ->within(new FormComponent, function ($browser) use ($tag) { $browser->searchFirstRelation('tags', $tag->id) ->type('@notes', 'Test Notes'); }) @@ -122,12 +122,12 @@ public function test_validation_errors_are_displayed() $browser->loginAs(1) ->visit(Attach::morphToMany('posts', $post->id, 'tags')) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink("User Post Details: {$post->id}") ->assertCurrentPageTitle('Attach Tag'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@notes', function ($browser) { $browser->type('', str_repeat('A', 30)); }); @@ -155,12 +155,12 @@ public function test_validation_errors_are_displayed_for_pivot_fields() $browser->loginAs(1) ->visit(Attach::morphToMany('posts', $post->id, 'tags')) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink("User Post Details: {$post->id}") ->assertCurrentPageTitle('Attach Tag'); }) - ->within(new FormComponent(), function ($browser) use ($tag) { + ->within(new FormComponent, function ($browser) use ($tag) { $browser->searchFirstRelation('tags', $tag->id) ->type('@notes', str_repeat('A', 30)); }) diff --git a/tests/Browser/AttachResourceFormAbandonmentTest.php b/tests/Browser/AttachResourceFormAbandonmentTest.php index 27b73159..77d62f2b 100644 --- a/tests/Browser/AttachResourceFormAbandonmentTest.php +++ b/tests/Browser/AttachResourceFormAbandonmentTest.php @@ -8,7 +8,9 @@ use Laravel\Nova\Testing\Browser\Pages\Detail; use Laravel\Nova\Testing\Browser\Pages\UserIndex; use Laravel\Nova\Tests\DuskTestCase; +use PHPUnit\Framework\Attributes\Group; +#[Group('form-abort')] class AttachResourceFormAbandonmentTest extends DuskTestCase { public function test_it_shows_exit_warning_if_resource_form_has_changes_when_navigating_to_different_page() @@ -23,7 +25,7 @@ public function test_it_shows_exit_warning_if_resource_form_has_changes_when_nav $browser->assertSee('User')->assertSee('Taylor Otwell'); }) ->keys('@notes', 'Test Notes', '{tab}') - ->within(new SidebarComponent(), function ($browser) { + ->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); }) ->waitForDialog() diff --git a/tests/Browser/AttachSoftDeletingTest.php b/tests/Browser/AttachSoftDeletingTest.php index 747fc54d..b6d47540 100755 --- a/tests/Browser/AttachSoftDeletingTest.php +++ b/tests/Browser/AttachSoftDeletingTest.php @@ -23,12 +23,12 @@ public function test_non_searchable_resource_can_be_attached() $browser->loginAs(1) ->visit(Attach::belongsToMany('captains', $captain->id, 'ships')) - ->within(new BreadcrumbComponent(), function ($browser) use ($captain) { + ->within(new BreadcrumbComponent, function ($browser) use ($captain) { $browser->assertSeeLink('Captains') ->assertSeeLink('Captain Details: '.$captain->id) ->assertCurrentPageTitle('Attach Ship'); }) - ->within(new FormComponent(), function ($browser) use ($ship) { + ->within(new FormComponent, function ($browser) use ($ship) { $browser->searchFirstRelation('ships', $ship->id); }) ->create() @@ -51,12 +51,12 @@ public function test_with_trashed_checkbox_is_respected_and_non_searchable_soft_ $browser->loginAs(1) ->visit(Attach::belongsToMany('captains', $captain->id, 'ships')) - ->within(new BreadcrumbComponent(), function ($browser) use ($captain) { + ->within(new BreadcrumbComponent, function ($browser) use ($captain) { $browser->assertSeeLink('Captains') ->assertSeeLink('Captain Details: '.$captain->id) ->assertCurrentPageTitle('Attach Ship'); }) - ->within(new FormComponent(), function ($browser) use ($ship) { + ->within(new FormComponent, function ($browser) use ($ship) { $browser->withTrashedRelation('ships') ->searchFirstRelation('ships', $ship->id); }) @@ -83,12 +83,12 @@ public function test_searchable_resource_can_be_attached() $browser->loginAs(1) ->visit(Attach::belongsToMany('captains', $captain->id, 'ships')) - ->within(new BreadcrumbComponent(), function ($browser) use ($captain) { + ->within(new BreadcrumbComponent, function ($browser) use ($captain) { $browser->assertSeeLink('Captains') ->assertSeeLink('Captain Details: '.$captain->id) ->assertCurrentPageTitle('Attach Ship'); }) - ->within(new FormComponent(), function ($browser) use ($ship) { + ->within(new FormComponent, function ($browser) use ($ship) { $browser->searchFirstRelation('ships', $ship->id); }) ->create() @@ -111,12 +111,12 @@ public function test_with_trashed_checkbox_is_respected_and_searchable_soft_dele $browser->loginAs(1) ->visit(Attach::belongsToMany('captains', $captain->id, 'ships')) - ->within(new BreadcrumbComponent(), function ($browser) use ($captain) { + ->within(new BreadcrumbComponent, function ($browser) use ($captain) { $browser->assertSeeLink('Captains') ->assertSeeLink('Captain Details: '.$captain->id) ->assertCurrentPageTitle('Attach Ship'); }) - ->within(new FormComponent(), function ($browser) use ($ship) { + ->within(new FormComponent, function ($browser) use ($ship) { $browser->withTrashedRelation('ships') ->searchFirstRelation('ships', $ship->id); }) diff --git a/tests/Browser/AttachTest.php b/tests/Browser/AttachTest.php index b6fa3fe2..089d58c5 100755 --- a/tests/Browser/AttachTest.php +++ b/tests/Browser/AttachTest.php @@ -22,7 +22,7 @@ public function test_resource_can_be_attached() $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'roles')) - ->within(new FormComponent(), function ($browser) use ($role) { + ->within(new FormComponent, function ($browser) use ($role) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -50,7 +50,7 @@ public function test_resource_can_be_attached_using_searchable() $browser->loginAs(1) ->visit(Attach::belongsToMany('roles', $role->id, 'users')) - ->within(new FormComponent(), function ($browser) use ($role) { + ->within(new FormComponent, function ($browser) use ($role) { $browser->whenAvailable('@via-resource-field', function ($browser) use ($role) { $browser->assertSee('Role')->assertSee($role->id); }) @@ -76,12 +76,12 @@ public function test_fields_on_intermediate_table_should_be_stored() $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'roles')) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Attach Role'); }) - ->within(new FormComponent(), function ($browser) use ($role) { + ->within(new FormComponent, function ($browser) use ($role) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -109,12 +109,12 @@ public function test_validation_errors_are_displayed() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'roles')) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Attach Role'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }); diff --git a/tests/Browser/AuthenticatesUserTest.php b/tests/Browser/AuthenticatesUserTest.php index 589f1530..4de2faff 100644 --- a/tests/Browser/AuthenticatesUserTest.php +++ b/tests/Browser/AuthenticatesUserTest.php @@ -21,7 +21,7 @@ public function test_it_redirect_to_intended_url_after_login($targetUrl, $expect $browser->logout() ->assertGuest() ->visit(Nova::url($targetUrl)) - ->on(new Login()) + ->on(new Login) ->type('email', 'nova@laravel.com') ->type('password', 'password') ->clickAndWaitForReload('button[type="submit"]') @@ -36,13 +36,13 @@ public function test_redirect_to_login_after_logout() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press('Taylor Otwell') ->press('Logout') ->waitForDialog() ->assertDialogOpened('Are you sure you want to log out?') ->acceptDialog() - ->on(new Login()) + ->on(new Login) ->assertGuest(); $browser->blank(); @@ -53,9 +53,9 @@ public function test_clear_user_association_after_logout() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->logout() - ->visit((new Dashboard())->url()) + ->visit((new Dashboard)->url()) ->waitForLocation('/nova/login') ->assertGuest(); @@ -66,11 +66,11 @@ public function test_clear_user_association_after_logout() public function test_clear_user_association_after_session_timeout() { $this->browse(function (Browser $browser) { - $browser->loginAs(1)->visit(new Dashboard()); + $browser->loginAs(1)->visit(new Dashboard); $browser->deleteCookie('nova_dusk_suite_session'); - $browser->within(new SidebarComponent(), function ($browser) { + $browser->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); })->waitForLocation('/nova/login') ->assertGuest(); @@ -82,7 +82,7 @@ public function test_clear_user_association_after_session_timeout() public function test_can_relogin_after_session_timeout() { $this->browse(function (Browser $browser) { - $browser->loginAs(1)->visit(new Dashboard()); + $browser->loginAs(1)->visit(new Dashboard); $browser->deleteCookie('nova_dusk_suite_session') ->script('Nova.$emit("token-expired")'); @@ -91,7 +91,7 @@ public function test_can_relogin_after_session_timeout() ->type('email', 'nova@laravel.com') ->type('password', 'password') ->clickAndWaitForReload('button[type="submit"]') - ->on(new Dashboard()); + ->on(new Dashboard); $browser->blank(); }); @@ -104,7 +104,7 @@ public function test_redirect_outside_of_nova_after_login() ->assertGuest() ->visit('/dashboard') ->waitForLocation('/login') - ->visit(new Login()) + ->visit(new Login) ->type('email', 'nova@laravel.com') ->type('password', 'password') ->clickAndWaitForReload('button[type="submit"]') diff --git a/tests/Browser/CreateResourceFormAbandonmentTest.php b/tests/Browser/CreateResourceFormAbandonmentTest.php index 73c2229c..4bbeb705 100644 --- a/tests/Browser/CreateResourceFormAbandonmentTest.php +++ b/tests/Browser/CreateResourceFormAbandonmentTest.php @@ -7,7 +7,9 @@ use Laravel\Nova\Testing\Browser\Pages\Index; use Laravel\Nova\Testing\Browser\Pages\UserIndex; use Laravel\Nova\Tests\DuskTestCase; +use PHPUnit\Framework\Attributes\Group; +#[Group('form-abort')] class CreateResourceFormAbandonmentTest extends DuskTestCase { public function test_it_shows_exit_warning_if_resource_form_has_changes_when_navigating_to_different_page() @@ -18,7 +20,7 @@ public function test_it_shows_exit_warning_if_resource_form_has_changes_when_nav ->runCreate(function ($browser) { $browser->keys('@title', 'Hello World', '{tab}'); }) - ->within(new SidebarComponent(), function ($browser) { + ->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); }) ->waitForDialog() diff --git a/tests/Browser/CreateTest.php b/tests/Browser/CreateTest.php index 3c12e136..b52fda8a 100755 --- a/tests/Browser/CreateTest.php +++ b/tests/Browser/CreateTest.php @@ -18,11 +18,11 @@ public function test_resource_can_be_created() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('users')) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertCurrentPageTitle('Create User'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', 'Adam Wathan') ->type('@email', 'adam@laravel.com') ->type('@password', 'secret') @@ -37,12 +37,12 @@ public function test_resource_can_be_created() ->assertQueryStringHas('viaResource', 'users') ->assertQueryStringHas('viaResourceId', $user->id) ->assertQueryStringHas('viaRelationship', 'profile') - ->within(new BreadcrumbComponent(), function ($browser) use ($user) { + ->within(new BreadcrumbComponent, function ($browser) use ($user) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: '.$user->name) ->assertCurrentPageTitle('Create Profile'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@github_url', 'https://github.com/adamwathan') ->type('@twitter_url', 'https://twitter.com/adamwathan') ->select('select[dusk="timezone"]', 'UTC') @@ -89,7 +89,7 @@ public function test_resource_can_be_created_and_another_resource_can_be_added() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('users')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', 'Adam Wathan') ->type('@email', 'adam@laravel.com') ->type('@password', 'secret'); diff --git a/tests/Browser/CreateWithBelongsToTest.php b/tests/Browser/CreateWithBelongsToTest.php index cbb2be17..970bce2e 100755 --- a/tests/Browser/CreateWithBelongsToTest.php +++ b/tests/Browser/CreateWithBelongsToTest.php @@ -22,7 +22,7 @@ public function test_resource_can_be_created() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('posts')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@title', 'Test Post') ->type('@body', 'Test Post Body') ->selectRelation('users', 1); @@ -48,7 +48,7 @@ public function test_toggling_with_trashed_on_belongs_to_field_resets_the_origin $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('profiles')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->withTrashedRelation('companies') ->selectRelation('companies', 3) ->withoutTrashedRelation('companies'); @@ -76,7 +76,7 @@ public function test_parent_resource_should_be_limited_when_creating_via_parents $browser->loginAs(1) ->visit(new Detail('users', 1)) ->runCreateRelation('posts') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable(new SearchInputComponent('users'), function ($browser) { $browser->assertSelectedSearchResult('Taylor Otwell'); }) @@ -102,7 +102,7 @@ public function test_searchable_resource_can_be_created() $this->browse(function (Browser $browser) use ($dock) { $browser->loginAs(1) ->visit(new Create('ships')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->searchFirstRelation('docks', '1') ->type('@name', 'Test Ship'); }) @@ -123,7 +123,7 @@ public function test_searchable_parent_resource_should_be_limited_when_creating_ $browser->loginAs(1) ->visit(new Detail('docks', 1)) ->runCreateRelation('ships') - ->within(new FormComponent(), function ($browser) use ($dock) { + ->within(new FormComponent, function ($browser) use ($dock) { $browser->assertSelectedSearchResult('docks', $dock->name) ->type('@name', 'Test Ship'); }) @@ -157,12 +157,12 @@ public function test_belongs_to_field_should_honor_query_parameters_on_create() 'viaRelationship' => 'posts', ])) ->waitForTextIn('@nova-form', 'Taylor Otwell') - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Create User Post'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSelectedSearchResult('users', 'Taylor Otwell'); }); diff --git a/tests/Browser/CreateWithHasManyThroughTest.php b/tests/Browser/CreateWithHasManyThroughTest.php index cd5b8a48..46438b6d 100644 --- a/tests/Browser/CreateWithHasManyThroughTest.php +++ b/tests/Browser/CreateWithHasManyThroughTest.php @@ -38,7 +38,7 @@ public function test_has_one_should_be_filled() ->click('@create-button'); }) ->on(new Create('sails')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@inches', '25'); }) ->create() diff --git a/tests/Browser/CreateWithInlineRelationButtonTest.php b/tests/Browser/CreateWithInlineRelationButtonTest.php index 96833387..32aa3e79 100644 --- a/tests/Browser/CreateWithInlineRelationButtonTest.php +++ b/tests/Browser/CreateWithInlineRelationButtonTest.php @@ -29,7 +29,7 @@ public function test_belongs_to_resource_should_fetch_the_related_resource_id_in $browser->loginAs(1) ->visit(new Create('sails')) - ->within(new FormComponent(), function ($browser) use ($dock) { + ->within(new FormComponent, function ($browser) use ($dock) { $browser->runInlineCreate('ship', function ($browser) use ($dock) { $browser->waitForText('Create Ship') ->searchFirstRelation('docks', $dock->id) @@ -38,7 +38,7 @@ public function test_belongs_to_resource_should_fetch_the_related_resource_id_in }) ->waitForText('The ship was created!') ->pause(500) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('Ship name') ->type('@inches', 25); }) @@ -59,7 +59,7 @@ public function test_searchable_belongs_to_resource_can_be_cancelled_and_use_dif $this->browse(function (Browser $browser) use ($dock) { $browser->loginAs(1) ->visit(new Create('sails')) - ->within(new FormComponent(), function ($browser) use ($dock) { + ->within(new FormComponent, function ($browser) use ($dock) { $browser->runInlineCreate('ship', function ($browser) use ($dock) { $browser->waitForText('Create Ship') ->searchFirstRelation('docks', $dock->id) @@ -68,7 +68,7 @@ public function test_searchable_belongs_to_resource_can_be_cancelled_and_use_dif }) ->waitForText('The ship was created!') ->pause(500) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->within(new SearchInputComponent('ships'), function ($browser) { $browser->assertSelectedFirstSearchResult('Ship name') ->resetSearchResult() @@ -95,7 +95,7 @@ public function test_morph_to_resource_can_be_created_with_attaching_file_to_par $browser->loginAs(4) ->visit(new Create('comments')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->select('@commentable-type', 'posts') ->runInlineCreate('commentable', function ($browser) { $browser->waitForText('Create User Post') @@ -111,7 +111,7 @@ public function test_morph_to_resource_can_be_created_with_attaching_file_to_par }); }) ->waitForText('The user post was created!') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@body', 'Test Comment Body'); }) ->create() @@ -141,7 +141,7 @@ public function test_morph_to_resource_can_be_created_with_attaching_file_to_chi $browser->loginAs(4) ->visit(new Create('comments')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->select('@commentable-type', 'posts') ->pause(500) ->runInlineCreate('commentable', function ($browser) { @@ -155,7 +155,7 @@ public function test_morph_to_resource_can_be_created_with_attaching_file_to_chi }); }) ->waitForText('The user post was created!') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@body', 'Test Comment Body') ->attach('@attachment', __DIR__.'/Fixtures/Document.pdf'); }) @@ -186,7 +186,7 @@ public function test_searchable_morph_to_resource_can_be_cancelled_and_use_diffe $browser->loginAs(1) ->visit(new Create('comments')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->select('@commentable-type', 'posts') ->pause(500) ->runInlineCreate('commentable', function ($browser) { @@ -197,7 +197,7 @@ public function test_searchable_morph_to_resource_can_be_cancelled_and_use_diffe }); }) ->waitForText('The user post was created!') - ->within(new FormComponent(), function ($browser) use ($post) { + ->within(new FormComponent, function ($browser) use ($post) { $browser->assertSelectedFirstSearchResult('commentable', 'Test Post') ->within(new SearchInputComponent('commentable'), function ($browser) use ($post) { $browser->resetSearchResult() @@ -224,7 +224,7 @@ public function test_belongs_to_many_resource_should_fetch_the_related_resource_ $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(Attach::belongsToMany('users', 1, 'roles')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->runInlineCreate('roles', function ($browser) { $browser->waitForText('Create Role') ->type('@name', 'Manager'); @@ -232,7 +232,7 @@ public function test_belongs_to_many_resource_should_fetch_the_related_resource_ }) ->waitForText('The role was created!') ->pause(500) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('Manager'); }) ->create() @@ -251,7 +251,7 @@ public function test_slug_not_affected_by_create_relation_modal() $browser->loginAs(1) ->visit(new Create('sails')) - ->within(new FormComponent(), function ($browser) use ($dock) { + ->within(new FormComponent, function ($browser) use ($dock) { $browser->type('@name', 'Test Sail') ->type('@inches', 350) ->runInlineCreate('ship', function ($browser) use ($dock) { @@ -280,7 +280,7 @@ public function test_tag_resource_should_fetch_the_related_resource_id_info() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Update('users', 1)) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertMissing('@projects-selected-tags') ->runInlineCreate('projects', function ($browser) { $browser->waitForText('Create Project') @@ -289,7 +289,7 @@ public function test_tag_resource_should_fetch_the_related_resource_id_info() }); }) ->waitForText('The project was created!') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@projects-selected-tags', function ($browser) { $browser->assertSeeIn('p', 'Vapor'); }); diff --git a/tests/Browser/CreateWithPolymorphicTest.php b/tests/Browser/CreateWithPolymorphicTest.php index d7477c17..e76f595e 100644 --- a/tests/Browser/CreateWithPolymorphicTest.php +++ b/tests/Browser/CreateWithPolymorphicTest.php @@ -24,7 +24,7 @@ public function test_non_searchable_resource_can_be_created_via_parent_resource( ->click('@create-button'); }) ->on(new Create('comments')) - ->within(new FormComponent(), function ($browser) use ($post) { + ->within(new FormComponent, function ($browser) use ($post) { $browser->assertDisabled('@commentable-type') ->assertSelectedSearchResult('commentable', $post->title) ->type('@body', 'Test Comment'); diff --git a/tests/Browser/CreateWithSoftDeletingMorphToTest.php b/tests/Browser/CreateWithSoftDeletingMorphToTest.php index 0741fe60..cddb5f19 100755 --- a/tests/Browser/CreateWithSoftDeletingMorphToTest.php +++ b/tests/Browser/CreateWithSoftDeletingMorphToTest.php @@ -21,7 +21,7 @@ public function test_parent_select_is_locked_when_creating_child_of_soft_deleted $browser->loginAs(1) ->visit(new Detail('videos', $video->id)) ->runCreateRelation('comments') - ->within(new FormComponent(), function ($browser) use ($video) { + ->within(new FormComponent, function ($browser) use ($video) { $browser->assertDisabled('@commentable-type') ->assertSelectedSearchResult('commentable', $video->title); }) diff --git a/tests/Browser/CustomAuthenticatesUserTest.php b/tests/Browser/CustomAuthenticatesUserTest.php index c43cffd1..196c6d5a 100644 --- a/tests/Browser/CustomAuthenticatesUserTest.php +++ b/tests/Browser/CustomAuthenticatesUserTest.php @@ -52,7 +52,7 @@ public function test_it_redirect_to_login_after_logout() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press('Taylor Otwell') ->press('Logout') ->waitForDialog() @@ -69,9 +69,9 @@ public function test_it_clear_user_association_after_logout() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->logout() - ->visit((new Dashboard())->url()) + ->visit((new Dashboard)->url()) ->waitForLocation('/login') ->assertGuest(); @@ -82,11 +82,11 @@ public function test_it_clear_user_association_after_logout() public function test_it_clear_user_association_after_session_timeout() { $this->browse(function (Browser $browser) { - $browser->loginAs(1)->visit(new Dashboard()); + $browser->loginAs(1)->visit(new Dashboard); $browser->deleteCookie('nova_dusk_suite_session'); - $browser->within(new SidebarComponent(), function ($browser) { + $browser->within(new SidebarComponent, function ($browser) { $browser->clickLink('Books'); })->waitForLocation('/login') ->assertGuest(); @@ -98,7 +98,7 @@ public function test_it_clear_user_association_after_session_timeout() public function test_it_can_relogin_after_session_timeout() { $this->browse(function (Browser $browser) { - $browser->loginAs(1)->visit(new Dashboard()); + $browser->loginAs(1)->visit(new Dashboard); $browser->deleteCookie('nova_dusk_suite_session') ->script('Nova.$emit("token-expired")'); diff --git a/tests/Browser/DashboardTest.php b/tests/Browser/DashboardTest.php index b47f31d4..60347feb 100644 --- a/tests/Browser/DashboardTest.php +++ b/tests/Browser/DashboardTest.php @@ -15,8 +15,8 @@ public function test_show_default_dashboard() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) - ->within(new BreadcrumbComponent(), function ($browser) { + ->visit(new Dashboard) + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSee('Dashboard') ->assertCurrentPageTitle('Main'); }) @@ -42,7 +42,7 @@ public function test_it_can_focus_global_search_using_shortcut() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->withKeyboard(function (Keyboard $keyboard) { $keyboard->type(['/']); }) diff --git a/tests/Browser/DependentActionFieldTest.php b/tests/Browser/DependentActionFieldTest.php index 674c6fb0..adb628d7 100644 --- a/tests/Browser/DependentActionFieldTest.php +++ b/tests/Browser/DependentActionFieldTest.php @@ -197,9 +197,9 @@ public function test_it_provides_selected_resources_information() ->visit(new Detail('captains', $captains[0]->getKey())) ->within(new DetailComponent('captains', $captains[0]->getKey()), function ($browser) use ($captains) { $browser->openControlSelector() - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) use ($captains) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) use ($captains) { $browser->click("button[data-action-id='track-selected-action']") - ->elsewhereWhenAvailable(new ConfirmActionModalComponent(), function ($browser) use ($captains) { + ->elsewhereWhenAvailable(new ConfirmActionModalComponent, function ($browser) use ($captains) { $browser->assertValue('@selected_resources', 'false - '.$captains[0]->getKey()) ->click('[id="toggle-default-boolean-field"]') ->pause(1000) diff --git a/tests/Browser/DependentBelongsToFieldTest.php b/tests/Browser/DependentBelongsToFieldTest.php index 47c879ab..d732ceab 100644 --- a/tests/Browser/DependentBelongsToFieldTest.php +++ b/tests/Browser/DependentBelongsToFieldTest.php @@ -108,7 +108,7 @@ public function test_it_reset_the_field_value() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('posts')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('Attachment') ->assertInputValue('@key-value-key-0', 'Author') ->assertInputValue('@key-value-value-0', 'Anonymous') diff --git a/tests/Browser/DependentBelongsToManyFieldTest.php b/tests/Browser/DependentBelongsToManyFieldTest.php index 9dca321d..694bd3c2 100644 --- a/tests/Browser/DependentBelongsToManyFieldTest.php +++ b/tests/Browser/DependentBelongsToManyFieldTest.php @@ -15,7 +15,7 @@ public function test_it_can_listen_to_related_field_changes() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Attach('users', 1, 'books', 'personalBooks')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('Attach Book') ->assertSeeIn('p.help-text', 'Price starts from $0-$99') ->within(new RelationSelectControlComponent('attachable'), function ($browser) { diff --git a/tests/Browser/DependentBooleanGroupFieldTest.php b/tests/Browser/DependentBooleanGroupFieldTest.php index ee9a6a19..ccb9e511 100644 --- a/tests/Browser/DependentBooleanGroupFieldTest.php +++ b/tests/Browser/DependentBooleanGroupFieldTest.php @@ -65,7 +65,7 @@ public function test_it_can_apply_can_apply_field_dependencies_when_updating() $browser->loginAs(1) ->visit(new Update('users', $user->id)) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@email', 'mior@laravel-nova.com')->pause(2000); })->update() ->waitForText('The user was updated!'); diff --git a/tests/Browser/DependentMultiSelectFieldTest.php b/tests/Browser/DependentMultiSelectFieldTest.php index 779abe3d..93f4ebf7 100644 --- a/tests/Browser/DependentMultiSelectFieldTest.php +++ b/tests/Browser/DependentMultiSelectFieldTest.php @@ -16,7 +16,7 @@ public function test_it_can_apply_depends_on_creating() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('profiles')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->selectRelation('users', 4) ->assertSelectHasOptions('@interests', [ 'laravel', @@ -49,7 +49,7 @@ public function test_it_can_apply_depends_on_updating() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Update('profiles', 1)) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSelectHasOptions('@interests', [ 'laravel', 'phpunit', diff --git a/tests/Browser/DetailActionTest.php b/tests/Browser/DetailActionTest.php index da168eb1..cab28dfa 100644 --- a/tests/Browser/DetailActionTest.php +++ b/tests/Browser/DetailActionTest.php @@ -123,7 +123,7 @@ public function test_actions_that_cannot_be_ran_are_disabled() $browser->loginAs(4) ->visit(new Detail('subscribers', $subscribers[0]->id)) ->openControlSelector() - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->assertDisabled('button[data-action-id="sleep"]'); }); diff --git a/tests/Browser/FileAttachTest.php b/tests/Browser/FileAttachTest.php index da18d0ed..b303f378 100755 --- a/tests/Browser/FileAttachTest.php +++ b/tests/Browser/FileAttachTest.php @@ -53,7 +53,7 @@ public function test_file_can_be_attached_to_resource() ->whenAvailable('button[dusk="photo-delete-link"]', function ($browser) { $browser->click(''); }) - ->whenAvailable(new ConfirmUploadRemovalModalComponent(), function ($browser) { + ->whenAvailable(new ConfirmUploadRemovalModalComponent, function ($browser) { $browser->confirm(); }) ->waitForText('The file was deleted!'); diff --git a/tests/Browser/FilterableBelongsToManyFieldTest.php b/tests/Browser/FilterableBelongsToManyFieldTest.php index a9222d44..036393ae 100644 --- a/tests/Browser/FilterableBelongsToManyFieldTest.php +++ b/tests/Browser/FilterableBelongsToManyFieldTest.php @@ -26,7 +26,7 @@ public function test_it_can_filter_belongs_to_many_field() $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() ->assertSeeResource(1) @@ -83,7 +83,7 @@ public function test_it_can_filter_belongs_to_many_field_via_relationship() ->waitForTable() ->assertQueryStringHas( 'books_filter', - 'W3sicmVzb3VyY2U6Ym9va3M6Z2lmdEJvb2tzIjoiNCJ9LHsiQm9vbGVhbjphY3RpdmUiOiIifSx7IkN1cnJlbmN5OnByaWNlIjpbbnVsbCxudWxsXX1d' + 'W3sicmVzb3VyY2U6Ym9va3M6Z2lmdEJvb2tzIjo0fSx7IkJvb2xlYW46YWN0aXZlIjoiIn0seyJDdXJyZW5jeTpwcmljZSI6W251bGwsbnVsbF19XQ==' ) ->assertSeeResource(4, 1) ->assertSeeResource(4, 2) @@ -96,7 +96,7 @@ public function test_it_can_filter_belongs_to_many_field_via_relationship() })->waitForTable() ->assertQueryStringHas( 'books_filter', - 'W3sicmVzb3VyY2U6Ym9va3M6Z2lmdEJvb2tzIjoiMyJ9LHsiQm9vbGVhbjphY3RpdmUiOiIifSx7IkN1cnJlbmN5OnByaWNlIjpbbnVsbCxudWxsXX1d' + 'W3sicmVzb3VyY2U6Ym9va3M6Z2lmdEJvb2tzIjozfSx7IkJvb2xlYW46YWN0aXZlIjoiIn0seyJDdXJyZW5jeTpwcmljZSI6W251bGwsbnVsbF19XQ==' ) ->assertDontSeeResource(4, 1) ->assertDontSeeResource(4, 2) @@ -137,7 +137,7 @@ public function test_it_can_filter_belongs_to_many_field_via_nested_relationship })->waitForTable() ->assertQueryStringHas( 'ships_filter', - base64_encode(json_encode([['resource:captains:captains' => "{$captain->getKey()}"]])) + base64_encode(json_encode([['resource:captains:captains' => $captain->getKey()]])) ) ->assertSeeResource($ship->getKey()) ->assertDontSeeResource($ship1->getKey()) @@ -149,7 +149,7 @@ public function test_it_can_filter_belongs_to_many_field_via_nested_relationship })->waitForTable() ->assertQueryStringHas( 'ships_filter', - base64_encode(json_encode([['resource:captains:captains' => "{$captain1->getKey()}"]])) + base64_encode(json_encode([['resource:captains:captains' => $captain1->getKey()]])) ) ->assertSeeResource($ship->getKey()) ->assertDontSeeResource($ship1->getKey()) diff --git a/tests/Browser/FilterableFieldTest.php b/tests/Browser/FilterableFieldTest.php index d3126a4a..e8c2c7ba 100644 --- a/tests/Browser/FilterableFieldTest.php +++ b/tests/Browser/FilterableFieldTest.php @@ -22,7 +22,7 @@ public function test_it_can_filter_boolean_field() $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() ->assertFilterCount(0) @@ -300,7 +300,7 @@ public function test_it_can_filter_date_field() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() ->runFilter(function ($browser) { diff --git a/tests/Browser/FormButtonTest.php b/tests/Browser/FormButtonTest.php index 192d3b0f..0e19d9e8 100644 --- a/tests/Browser/FormButtonTest.php +++ b/tests/Browser/FormButtonTest.php @@ -21,7 +21,7 @@ public function test_it_can_handle_native_form_request() $browser->loginAs($user) ->visit(new Dashboard) - ->within(new HeaderComponent(), function (Browser $browser) use ($user) { + ->within(new HeaderComponent, function (Browser $browser) use ($user) { $browser->press($user->name) ->elsewhereWhenAvailable('[data-menu-open=true]', function ($browser) { $browser->press('Verify Account'); @@ -43,7 +43,7 @@ public function test_it_can_handle_inertia_form_request() $browser->loginAs($user) ->visit(new Dashboard) - ->within(new SidebarComponent(), function (Browser $browser) { + ->within(new SidebarComponent, function (Browser $browser) { $browser->press('Verify Using Inertia'); })->on(new Detail('users', $user->id)); diff --git a/tests/Browser/GlobalSearchTest.php b/tests/Browser/GlobalSearchTest.php index 8515f17a..603eaa4e 100644 --- a/tests/Browser/GlobalSearchTest.php +++ b/tests/Browser/GlobalSearchTest.php @@ -16,7 +16,7 @@ public function test_it_closes_the_search_results_when_search_query_is_empty() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->within('@global-search-component', function ($browser) { $browser->type('@global-search', 'a') ->elsewhereWhenAvailable('@global-search-results', function ($browser) { @@ -45,7 +45,7 @@ public function test_it_can_search_resource_as_big_int() $this->browse(function (Browser $browser) use ($user) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->within('@global-search-component', function ($browser) use ($user) { $browser->type('@global-search', $user->getKey()) ->elsewhereWhenAvailable('@global-search-results', function ($browser) { @@ -65,7 +65,7 @@ public function test_it_can_use_control_click_to_open_on_new_tab() $currentWindowHandles = count($browser->driver->getWindowHandles()); $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->within('@global-search-component', function ($browser) { $browser->type('@global-search', 'taylor') ->elsewhereWhenAvailable('@global-search-results', function ($browser) { diff --git a/tests/Browser/HasOneAuthorizationTest.php b/tests/Browser/HasOneAuthorizationTest.php index a24648a4..aae597f3 100644 --- a/tests/Browser/HasOneAuthorizationTest.php +++ b/tests/Browser/HasOneAuthorizationTest.php @@ -20,7 +20,7 @@ public function test_it_can_create_users_without_authorization_to_profile() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Create('users')) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertMissing('@create-profile-relation-button') ->type('@name', 'Adam Wathan') ->type('@email', 'adam@laravel.com') diff --git a/tests/Browser/ImpersonatesUserTest.php b/tests/Browser/ImpersonatesUserTest.php index 784d5348..2c6b04a9 100644 --- a/tests/Browser/ImpersonatesUserTest.php +++ b/tests/Browser/ImpersonatesUserTest.php @@ -78,7 +78,7 @@ public function test_it_can_impersonate_another_user() }) ->closeCurrentDropdown(); }) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press('Laravel Nova') ->press('Stop Impersonating') ->waitForDialog() @@ -144,7 +144,7 @@ public function test_it_can_impersonate_another_user_with_different_password() ->assertMissing('@5-impersonate-button'); }); }) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press($user->name) ->press('Stop Impersonating') ->waitForDialog() @@ -181,7 +181,7 @@ public function test_it_can_impersonate_another_user_using_different_guard() ->assertAuthenticatedAs($subscriber, 'web-subscribers'); }); }) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press($user->name) ->press('Stop Impersonating') ->waitForDialog() @@ -223,7 +223,7 @@ public function test_it_can_impersonate_another_user_using_different_guard_with_ ->assertAuthenticatedAs($subscriber); }); }) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->press($user->name) ->press('Stop Impersonating') ->waitForDialog() diff --git a/tests/Browser/IndexActionTest.php b/tests/Browser/IndexActionTest.php index bcbbc625..b056129c 100644 --- a/tests/Browser/IndexActionTest.php +++ b/tests/Browser/IndexActionTest.php @@ -159,7 +159,7 @@ public function test_can_run_table_row_actions_on_selected_resources() }) ->closeCurrentDropdown() ->openControlSelectorById(2) - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->assertSee('Mark As Inactive'); }) ->closeCurrentDropdown() diff --git a/tests/Browser/IndexAuthorizationTest.php b/tests/Browser/IndexAuthorizationTest.php index 0d731b4e..9622c0cc 100755 --- a/tests/Browser/IndexAuthorizationTest.php +++ b/tests/Browser/IndexAuthorizationTest.php @@ -24,12 +24,12 @@ public function test_resource_index_can_be_totally_blocked_via_view_any() $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->assertDontSeeIn('div[dusk="sidebar-menu"][role="navigation"]', 'User Posts') ->visit(new Page('/resources/posts')) ->assertForbidden(); - $browser->visit(new Dashboard()) + $browser->visit(new Dashboard) ->assertDontSeeIn('div[dusk="sidebar-menu"][role="navigation"]', 'Users') ->visit(new Page('/resources/users')) ->assertForbidden() diff --git a/tests/Browser/IndexPreviewTest.php b/tests/Browser/IndexPreviewTest.php index 36baf6d7..fa239427 100644 --- a/tests/Browser/IndexPreviewTest.php +++ b/tests/Browser/IndexPreviewTest.php @@ -19,7 +19,7 @@ public function test_it_can_display_preview_modal() ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() ->previewResourceById(1) - ->elsewhereWhenAvailable(new PreviewResourceModalComponent(), function ($browser) { + ->elsewhereWhenAvailable(new PreviewResourceModalComponent, function ($browser) { $browser->assertSee('PREVIEWING TAYLOR OTWELL') ->assertSeeIn('@name', 'Taylor Otwell') ->assertSeeIn('@email', 'taylor@laravel.com') diff --git a/tests/Browser/IndexSearchTest.php b/tests/Browser/IndexSearchTest.php index afdb8f70..4d0341bf 100644 --- a/tests/Browser/IndexSearchTest.php +++ b/tests/Browser/IndexSearchTest.php @@ -55,7 +55,7 @@ public function test_resources_search_query_will_reset_on_revisit() ->assertDontSeeResource(4) ->assertQueryStringHas('users_search', '3'); }) - ->within(new SidebarComponent(), function ($browser) { + ->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); }) ->waitForTextIn('h1', 'Users') diff --git a/tests/Browser/IndexTest.php b/tests/Browser/IndexTest.php index 601b8f82..8be2786d 100755 --- a/tests/Browser/IndexTest.php +++ b/tests/Browser/IndexTest.php @@ -26,7 +26,7 @@ public function test_resource_index_can_be_viewed() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new UserIndex) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSee('Resources') ->assertCurrentPageTitle('Users'); }) @@ -252,7 +252,7 @@ public function test_resource_index_can_show_contents_even_when_set_as_collapsed $this->browse(function (Browser $browser) use ($role) { $browser->loginAs(1) - ->visit(new Dashboard()); + ->visit(new Dashboard); $browser->script('localStorage.setItem("nova.resources.roles.collapsed", true)'); diff --git a/tests/Browser/InlineActionDropdownTest.php b/tests/Browser/InlineActionDropdownTest.php index 2484b473..49ec6207 100644 --- a/tests/Browser/InlineActionDropdownTest.php +++ b/tests/Browser/InlineActionDropdownTest.php @@ -15,7 +15,7 @@ public function test_it_is_present_when_it_does_contains_any_items() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() ->assertPresentControlSelectorById(1) diff --git a/tests/Browser/InlineCreateResourceModalAbandonmentTest.php b/tests/Browser/InlineCreateResourceModalAbandonmentTest.php index fb268eaa..46ed991a 100644 --- a/tests/Browser/InlineCreateResourceModalAbandonmentTest.php +++ b/tests/Browser/InlineCreateResourceModalAbandonmentTest.php @@ -5,7 +5,9 @@ use Laravel\Dusk\Browser; use Laravel\Nova\Testing\Browser\Pages\Attach; use Laravel\Nova\Tests\DuskTestCase; +use PHPUnit\Framework\Attributes\Group; +#[Group('form-abort')] class InlineCreateResourceModalAbandonmentTest extends DuskTestCase { public function test_it_shows_exit_warning_dialog_if_modal_has_changes_when_pressing_escape() diff --git a/tests/Browser/LensActionTest.php b/tests/Browser/LensActionTest.php index 97d26372..0ee9be4a 100644 --- a/tests/Browser/LensActionTest.php +++ b/tests/Browser/LensActionTest.php @@ -46,13 +46,13 @@ public function test_can_run_table_row_actions_on_selected_resources() ->within(new LensComponent('users', 'passthrough-lens'), function ($browser) { $browser->waitForTable() ->openControlSelectorById(1) - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->waitFor('@1-preview-button') ->assertMissing('@1-inline-actions'); }) ->closeCurrentDropdown() ->openControlSelectorById(2) - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->assertSee('Mark As Inactive'); }) ->closeCurrentDropdown() diff --git a/tests/Browser/LensTest.php b/tests/Browser/LensTest.php index 133e14e5..be4c33ed 100755 --- a/tests/Browser/LensTest.php +++ b/tests/Browser/LensTest.php @@ -20,7 +20,7 @@ public function test_resource_lens_can_be_viewed() $this->browse(function (Browser $browser) { $browser->loginAs(1) ->visit(new Lens('users', 'passthrough-lens')) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSee('Resources') ->assertSeeLink('Users') ->assertCurrentPageTitle('Passthrough Lens'); diff --git a/tests/Browser/MainMenuTest.php b/tests/Browser/MainMenuTest.php index b86da00e..cd3b7f5a 100644 --- a/tests/Browser/MainMenuTest.php +++ b/tests/Browser/MainMenuTest.php @@ -32,14 +32,14 @@ public function test_resource_link_is_not_active_when_visiting_lens_with_custom_ $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) - ->within(new SidebarComponent(), function ($browser) { + ->visit(new UserIndex) + ->within(new SidebarComponent, function ($browser) { $browser->assertPresent('@current-active-link') ->assertSeeIn('@current-active-link', 'Users') ->assertDontSeeIn('@current-active-link', 'Passthrough Lens'); }) ->visit(new Lens('users', 'passthrough-lens')) - ->whenAvailable(new SidebarComponent(), function ($browser) { + ->whenAvailable(new SidebarComponent, function ($browser) { $browser->assertPresent('@current-active-link') ->assertDontSeeIn('@current-active-link', 'Users') ->assertSeeIn('@current-active-link', 'Passthrough Lens'); @@ -51,13 +51,13 @@ public function test_resource_link_not_active_when_visiting_lens_with_default_ma { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) - ->within(new SidebarComponent(), function ($browser) { + ->visit(new UserIndex) + ->within(new SidebarComponent, function ($browser) { $browser->assertPresent('@current-active-link') ->assertSeeIn('@current-active-link', 'Users'); }) ->visit(new Lens('users', 'passthrough-lens')) - ->whenAvailable(new SidebarComponent(), function ($browser) { + ->whenAvailable(new SidebarComponent, function ($browser) { $browser->assertMissing('@current-active-link'); }); }); diff --git a/tests/Browser/ModalTest.php b/tests/Browser/ModalTest.php index bfe9180c..cc4f553f 100644 --- a/tests/Browser/ModalTest.php +++ b/tests/Browser/ModalTest.php @@ -22,9 +22,9 @@ public function test_it_can_closed_searchable_belongs_to_field_dropdown() $browser->loginAs(1) ->visit(new Detail('posts', $post->id)) ->openControlSelector() - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->click("button[data-action-id='add-comment']") - ->elsewhereWhenAvailable(new ConfirmActionModalComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ConfirmActionModalComponent, function ($browser) { $browser->click('@anonymous-default-boolean-field') ->elsewhereWhenAvailable(new SearchInputComponent('users'), function ($browser) { $browser->showSearchDropdown(); @@ -50,9 +50,9 @@ public function test_it_can_closed_searchable_select_field_dropdown() $browser->loginAs(1) ->visit(new Detail('users', 4)) ->openControlSelector() - ->elsewhereWhenAvailable(new ActionDropdownComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ActionDropdownComponent, function ($browser) { $browser->click("button[data-action-id='create-user-profile']") - ->elsewhereWhenAvailable(new ConfirmActionModalComponent(), function ($browser) { + ->elsewhereWhenAvailable(new ConfirmActionModalComponent, function ($browser) { $browser->click('@timezone-search-input') ->elsewhereWhenAvailable(new SearchInputComponent('timezone'), function ($browser) { $browser->showSearchDropdown(); diff --git a/tests/Browser/NotificationTest.php b/tests/Browser/NotificationTest.php index a8fb6919..32ca82c9 100644 --- a/tests/Browser/NotificationTest.php +++ b/tests/Browser/NotificationTest.php @@ -24,8 +24,8 @@ public function test_it_can_view_own_notitications() $this->browse(function (Browser $browser) use ($user) { $browser->loginAs($user) - ->visit(new Dashboard()) - ->within(new HeaderComponent(), function ($browser) { + ->visit(new Dashboard) + ->within(new HeaderComponent, function ($browser) { $browser->showNotificationPanel(function ($browser) { $browser->assertSee('Just a test notification'); }); @@ -48,8 +48,8 @@ public function test_it_can_mark_own_notitications_as_read() $notification = Notification::latest()->first(); $browser->loginAs($user) - ->visit(new Dashboard()) - ->within(new HeaderComponent(), function ($browser) { + ->visit(new Dashboard) + ->within(new HeaderComponent, function ($browser) { $browser->showNotificationPanel(function ($browser) { $browser->click('@mark-as-read-button'); }); diff --git a/tests/Browser/PaginationTest.php b/tests/Browser/PaginationTest.php index 68e1d049..472e65f8 100644 --- a/tests/Browser/PaginationTest.php +++ b/tests/Browser/PaginationTest.php @@ -27,7 +27,7 @@ public function test_it_can_navigate_from_exceeding_page_using_simple_pagination ->assertDisabled('nav button[dusk="next"]') ->assertEnabled('nav button[dusk="previous"]') ->previousPage(); - })->on(new UserIndex()) + })->on(new UserIndex) ->assertQueryStringHas('users_page', 1); $browser->blank(); @@ -52,7 +52,7 @@ public function test_it_can_navigate_from_exceeding_page_using_links_pagination( ->assertEnabled('nav button[dusk="previous"]') ->assertEnabled('nav button[dusk="first"]') ->previousPage(); - })->on(new UserIndex()) + })->on(new UserIndex) ->assertQueryStringHas('users_page', 1); $browser->blank(); diff --git a/tests/Browser/PivotFileAttachTest.php b/tests/Browser/PivotFileAttachTest.php index 0203325a..c91ca74f 100755 --- a/tests/Browser/PivotFileAttachTest.php +++ b/tests/Browser/PivotFileAttachTest.php @@ -27,7 +27,7 @@ public function test_file_can_be_attached_to_resource() $browser->loginAs(1) ->visit(Attach::belongsToMany('captains', $captain->id, 'ships')) - ->within(new FormComponent(), function ($browser) use ($ship) { + ->within(new FormComponent, function ($browser) use ($ship) { $browser->searchFirstRelation('ships', $ship->id) ->attach('@contract', __DIR__.'/Fixtures/Document.pdf'); }) @@ -92,7 +92,7 @@ public function test_file_can_be_detached_from_edit_attached_screen() ->whenAvailable('button[dusk="contract-delete-link"]', function ($browser) { $browser->click(''); }) - ->whenAvailable(new ConfirmUploadRemovalModalComponent(), function ($browser) { + ->whenAvailable(new ConfirmUploadRemovalModalComponent, function ($browser) { $browser->confirm(); }) ->waitForText('The file was deleted!'); diff --git a/tests/Browser/RemoveAttachedTest.php b/tests/Browser/RemoveAttachedTest.php index dd33787f..7243816f 100644 --- a/tests/Browser/RemoveAttachedTest.php +++ b/tests/Browser/RemoveAttachedTest.php @@ -41,7 +41,7 @@ public function test_it_can_remove_attached_duplicate_relations_pivot() ->assertPresent("tr[data-pivot-id='{$book2->getKey()}']") ->within("tr[data-pivot-id='{$book2->getKey()}']", function ($browser) { $browser->click('@4-delete-button') - ->elsewhereWhenAvailable(new DeleteResourceModalComponent(), function ($browser) { + ->elsewhereWhenAvailable(new DeleteResourceModalComponent, function ($browser) { $browser->confirm(); })->pause(500); })->waitForTable() diff --git a/tests/Browser/RepeaterFieldTest.php b/tests/Browser/RepeaterFieldTest.php index cd2544d8..a69a0ad1 100644 --- a/tests/Browser/RepeaterFieldTest.php +++ b/tests/Browser/RepeaterFieldTest.php @@ -26,7 +26,7 @@ public function test_it_can_remove_a_row() $this->browse(function (Browser $browser) use ($invoice) { $browser->loginAs(1) ->visit(new Update('invoices', $invoice->getKey())) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@items', function ($browser) { $browser->assertValue('[dusk="0-repeater-row"] input[dusk="quantity"]', 1) ->assertValue('[dusk="1-repeater-row"] input[dusk="quantity"]', 2) @@ -55,7 +55,7 @@ public function test_it_can_move_up_a_row() $this->browse(function (Browser $browser) use ($invoice) { $browser->loginAs(1) ->visit(new Update('invoices', $invoice->getKey())) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@items', function ($browser) { $browser->assertValue('[dusk="0-repeater-row"] input[dusk="quantity"]', 1) ->assertValue('[dusk="1-repeater-row"] input[dusk="quantity"]', 2) @@ -85,7 +85,7 @@ public function test_it_can_move_down_a_row() $this->browse(function (Browser $browser) use ($invoice) { $browser->loginAs(1) ->visit(new Update('invoices', $invoice->getKey())) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@items', function ($browser) { $browser->assertValue('[dusk="0-repeater-row"] input[dusk="quantity"]', 1) ->assertValue('[dusk="1-repeater-row"] input[dusk="quantity"]', 2) diff --git a/tests/Browser/ReplicateTest.php b/tests/Browser/ReplicateTest.php index 76874ede..01afc27e 100644 --- a/tests/Browser/ReplicateTest.php +++ b/tests/Browser/ReplicateTest.php @@ -26,11 +26,11 @@ public function test_can_replicate_a_resource() $this->browse(function (Browser $browser) use ($post) { $browser->loginAs(1) ->visit(new Replicate('posts', $post->id)) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSee('User Post Details: '.$post->id) ->assertCurrentPageTitle('Replicate User Post'); }) - ->within(new FormComponent(), function ($browser) use ($post) { + ->within(new FormComponent, function ($browser) use ($post) { $browser->whenAvailable('@title', function ($browser) { $browser->type('', 'Replicated Post'); }) @@ -63,11 +63,11 @@ public function test_can_replicate_a_resource_without_deletable_field() $this->browse(function (Browser $browser) use ($post) { $browser->loginAs(1) ->visit(new Replicate('posts', $post->id)) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSee('User Post Details: '.$post->id) ->assertCurrentPageTitle('Replicate User Post'); }) - ->within(new FormComponent(), function ($browser) use ($post) { + ->within(new FormComponent, function ($browser) use ($post) { $browser->whenAvailable('@title', function ($browser) { $browser->type('', 'Replicated Post 2'); }) @@ -97,13 +97,13 @@ public function test_can_navigate_to_replicate_resource_screen() ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable()->replicateResourceById(2); }) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSee('User Details: James Brooks') ->assertCurrentPageTitle('Replicate User'); }) ->waitForText('Create User') ->assertSeeIn('h1', 'Create User') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertInputValue('@name', 'James Brooks') ->assertInputValue('@email', 'james@laravel.com') ->assertSee('Create & Add Another') diff --git a/tests/Browser/ResourceClickActionTest.php b/tests/Browser/ResourceClickActionTest.php index 869b5f23..01cda675 100644 --- a/tests/Browser/ResourceClickActionTest.php +++ b/tests/Browser/ResourceClickActionTest.php @@ -16,7 +16,7 @@ public function test_it_handle_default_option() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function (Browser $browser) { $browser->click('tr[dusk="3-row"] td:nth-child(3)'); }) @@ -38,32 +38,32 @@ public function test_it_can_be_configured() }; $browser->loginAs($fetchUser(1, 'detail')) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function (Browser $browser) { $browser->click('tr[dusk="3-row"] td:nth-child(3)'); }) ->waitForLocation((new Detail('users', 3))->url()); $browser->loginAs($fetchUser(2, 'edit')) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function (Browser $browser) { $browser->click('tr[dusk="3-row"] td:nth-child(3)'); }) ->waitForLocation((new Update('users', 3))->url()); $browser->loginAs($fetchUser(3, 'select')) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function (Browser $browser) { $browser->click('tr[dusk="3-row"] td:nth-child(3)') ->assertCheckboxChecked('[dusk="3-row"] [role="checkbox"]'); }); $browser->loginAs($fetchUser(4, 'ignore')) - ->visit(new UserIndex()) + ->visit(new UserIndex) ->within(new IndexComponent('users'), function (Browser $browser) { $browser->click('tr[dusk="3-row"] td:nth-child(3)') ->assertCheckboxNotChecked('[dusk="3-row"] [role="checkbox"]'); - })->assertPathIs((new UserIndex())->url()); + })->assertPathIs((new UserIndex)->url()); $browser->blank(); }); diff --git a/tests/Browser/ResourceTableSelectionTest.php b/tests/Browser/ResourceTableSelectionTest.php index 77c11205..c429feef 100644 --- a/tests/Browser/ResourceTableSelectionTest.php +++ b/tests/Browser/ResourceTableSelectionTest.php @@ -20,7 +20,7 @@ public function test_can_select_all_matching_on_single_page() ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->assertCheckboxIsNotChecked() ->assertSelectAllOnCurrentPageNotChecked() ->assertSelectAllMatchingNotChecked(); @@ -29,7 +29,7 @@ public function test_can_select_all_matching_on_single_page() ->clickCheckboxForId(3) ->clickCheckboxForId(2) ->clickCheckboxForId(1) - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->assertCheckboxIsIndeterminate() ->assertSelectAllOnCurrentPageChecked() ->assertSelectAllMatchingNotChecked() @@ -40,7 +40,7 @@ public function test_can_select_all_matching_on_single_page() $browser->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->selectAllOnCurrentPage() ->assertCheckboxIsIndeterminate() ->assertSelectAllOnCurrentPageChecked() @@ -62,7 +62,7 @@ public function test_can_select_all_matching_on_multiple_page() ->visit(new UserIndex) ->within(new IndexComponent('users'), function ($browser) { $browser->waitForTable() - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->selectAllOnCurrentPage() ->assertCheckboxIsIndeterminate() ->assertSelectAllOnCurrentPageChecked() @@ -92,7 +92,7 @@ public function test_can_unselect_all_on_single_page() ->assertNotChecked('[dusk="2-row"] [role="checkbox"]') ->assertNotChecked('[dusk="3-row"] [role="checkbox"]') ->assertNotChecked('[dusk="4-row"] [role="checkbox"]') - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->assertCheckboxIsNotChecked() ->assertSelectAllOnCurrentPageNotChecked() ->assertSelectAllMatchingNotChecked() @@ -117,7 +117,7 @@ public function test_can_unselect_all_matching_on_single_page() ->assertCheckboxChecked('[dusk="3-row"] [role="checkbox"]') ->assertCheckboxChecked('[dusk="4-row"] [role="checkbox"]') ->unselectAllMatching() - ->within(new SelectAllDropdownComponent(), function (Browser $browser) { + ->within(new SelectAllDropdownComponent, function (Browser $browser) { $browser->assertCheckboxIsIndeterminate(); }); }); diff --git a/tests/Browser/TagFieldTest.php b/tests/Browser/TagFieldTest.php index 0c984162..83b9873f 100644 --- a/tests/Browser/TagFieldTest.php +++ b/tests/Browser/TagFieldTest.php @@ -22,7 +22,7 @@ public function test_it_can_attach_relationship_using_tag_field() $browser->loginAs(1) ->visit(new Update('flights', $flight->getKey())) - ->within(new FormComponent(), function ($browser) use ($passports) { + ->within(new FormComponent, function ($browser) use ($passports) { $browser->assertMissing('@passports-selected-tags') ->within(new SearchSearchInputComponent('passports'), function ($browser) use ($passports) { $browser->searchAndSelectFirstResult($passports[0]->getKey()); diff --git a/tests/Browser/ToolAuthorizationTest.php b/tests/Browser/ToolAuthorizationTest.php index 76eb00ba..bd2670c4 100755 --- a/tests/Browser/ToolAuthorizationTest.php +++ b/tests/Browser/ToolAuthorizationTest.php @@ -15,7 +15,7 @@ public function test_tool_can_be_seen_if_authorized_to_view_it() { $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->pause(250) ->assertSee('Sidebar Tool'); @@ -44,7 +44,7 @@ public function test_tool_cant_be_seen_if_not_authorized_to_view_it() $this->browse(function (Browser $browser) { $browser->loginAs(1) - ->visit(new Dashboard()) + ->visit(new Dashboard) ->pause(250) ->assertDontSee('Sidebar Tool'); diff --git a/tests/Browser/UpdateAttachedResourceFormAbandonmentTest.php b/tests/Browser/UpdateAttachedResourceFormAbandonmentTest.php index 8ada5f13..441caffc 100644 --- a/tests/Browser/UpdateAttachedResourceFormAbandonmentTest.php +++ b/tests/Browser/UpdateAttachedResourceFormAbandonmentTest.php @@ -10,7 +10,9 @@ use Laravel\Nova\Testing\Browser\Pages\UpdateAttached; use Laravel\Nova\Testing\Browser\Pages\UserIndex; use Laravel\Nova\Tests\DuskTestCase; +use PHPUnit\Framework\Attributes\Group; +#[Group('form-abort')] class UpdateAttachedResourceFormAbandonmentTest extends DuskTestCase { public function test_it_shows_exit_warning_if_resource_form_has_changes_when_navigating_to_different_page() @@ -30,7 +32,7 @@ public function test_it_shows_exit_warning_if_resource_form_has_changes_when_nav $browser->assertSee('User')->assertSee('Taylor Otwell'); }) ->keys('@notes', 'Test Notes Updated', '{tab}') - ->within(new SidebarComponent(), function ($browser) { + ->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); }) ->waitForDialog() diff --git a/tests/Browser/UpdateAttachedTest.php b/tests/Browser/UpdateAttachedTest.php index 1ed00864..f1942ddd 100755 --- a/tests/Browser/UpdateAttachedTest.php +++ b/tests/Browser/UpdateAttachedTest.php @@ -29,12 +29,12 @@ public function test_attached_resource_can_be_updated() ->click('@1-edit-attached-button'); }) ->on(UpdateAttached::belongsToMany('users', 1, 'roles', 1)) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Update attached Role: 1'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -68,12 +68,12 @@ public function test_attached_resource_can_be_updated_and_can_continue_editing() ->click('@1-edit-attached-button'); }) ->on(UpdateAttached::belongsToMany('users', 1, 'roles', 1)) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Update attached Role: 1'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -110,12 +110,12 @@ public function test_validation_errors_are_displayed() ->click('@1-edit-attached-button'); }) ->on(UpdateAttached::belongsToMany('users', 1, 'roles', 1)) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Update attached Role: 1'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) @@ -156,12 +156,12 @@ public function test_it_can_update_attached_duplicate_relations_pivot() }); }) ->on(UpdateAttached::belongsToMany('users', 1, 'books', 4)) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor Otwell') ->assertCurrentPageTitle('Update attached Book: laravel-testing-decoded'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->whenAvailable('@via-resource-field', function ($browser) { $browser->assertSee('User')->assertSee('Taylor Otwell'); }) diff --git a/tests/Browser/UpdateResourceFormAbandonmentTest.php b/tests/Browser/UpdateResourceFormAbandonmentTest.php index 11159836..47d790a5 100644 --- a/tests/Browser/UpdateResourceFormAbandonmentTest.php +++ b/tests/Browser/UpdateResourceFormAbandonmentTest.php @@ -10,7 +10,9 @@ use Laravel\Nova\Testing\Browser\Pages\Update; use Laravel\Nova\Testing\Browser\Pages\UserIndex; use Laravel\Nova\Tests\DuskTestCase; +use PHPUnit\Framework\Attributes\Group; +#[Group('form-abort')] class UpdateResourceFormAbandonmentTest extends DuskTestCase { public function test_it_shows_exit_warning_if_resource_form_has_changes_when_navigating_to_different_page() @@ -23,7 +25,7 @@ public function test_it_shows_exit_warning_if_resource_form_has_changes_when_nav $browser->loginAs(1) ->visit(new Update('videos', $video->id)) ->type('@title', 'Hello World') - ->within(new SidebarComponent(), function ($browser) { + ->within(new SidebarComponent, function ($browser) { $browser->clickLink('Users'); }) ->waitForDialog() @@ -77,7 +79,7 @@ public function test_it_doesnt_show_exit_warning_if_resource_form_has_changes_wh ->visit(new Update('videos', $video->id)) ->type('@title', 'Hello World') ->cancel() - ->on(new Index('videos')); + ->on(new Detail('videos', $video->id)); $this->assertDatabaseMissing('videos', [ 'title' => 'Hello World', diff --git a/tests/Browser/UpdateTest.php b/tests/Browser/UpdateTest.php index cd4c253c..a6fd243a 100755 --- a/tests/Browser/UpdateTest.php +++ b/tests/Browser/UpdateTest.php @@ -43,7 +43,7 @@ public function test_validation_errors_are_displayed() $browser->loginAs(1) ->visit(new Update('users', 1)) ->waitForTextIn('h1', 'Update User: Taylor Otwell') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', ' '); }) ->update() @@ -67,12 +67,12 @@ public function test_resource_can_be_updated() $browser->loginAs(2) ->visit(new Update('users', 1)) ->waitForTextIn('h1', 'Update User: Taylor') - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: Taylor') ->assertCurrentPageTitle('Update User'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('E-mail address should be unique') ->assertSelected('@settings->pagination', 'simple') ->type('@name', 'Taylor Otwell upDATED') @@ -97,7 +97,7 @@ public function test_resource_can_be_updated_and_user_can_continue_editing() $browser->loginAs(2) ->visit(new Update('users', 1)) ->waitForTextIn('h1', 'Update User: Taylor Otwell') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', 'Taylor Otwell Updated') ->type('@password', 'secret') ->assertSee('E-mail address should be unique'); @@ -121,7 +121,7 @@ public function test_resource_can_be_updated_using_enter_key_and_redirected_to_d $browser->loginAs(2) ->visit(new Update('users', 1)) ->waitForTextIn('h1', 'Update User: Taylor Otwell') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@password', 'secret') ->type('@name', 'Taylor Otwell Updated') ->keys('@name', '{enter}'); @@ -149,7 +149,7 @@ public function test_user_isnt_logged_out_when_updating_their_own_resource() $browser->loginAs(1) ->visit(new Update('users', 1)) ->waitForTextIn('h1', 'Update User: Taylor') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSee('E-mail address should be unique') ->assertSelected('@settings->pagination', 'simple') ->type('@name', 'Taylor Otwell upDATED') diff --git a/tests/Browser/UpdateWithBelongsToTest.php b/tests/Browser/UpdateWithBelongsToTest.php index 79c40ff8..199cc5c6 100755 --- a/tests/Browser/UpdateWithBelongsToTest.php +++ b/tests/Browser/UpdateWithBelongsToTest.php @@ -22,12 +22,12 @@ public function test_resource_can_be_updated_to_new_parent() $browser->loginAs(1) ->visit(new Update('posts', $post->id)) ->waitForTextIn('h1', 'Update User Post: '.$post->id) - ->within(new BreadcrumbComponent(), function ($browser) use ($post) { + ->within(new BreadcrumbComponent, function ($browser) use ($post) { $browser->assertSeeLink('User Post') ->assertSeeLink('User Post Details: '.$post->id) ->assertCurrentPageTitle('Update User Post'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertMissing('@user-unlock-relation') ->selectRelation('users', 2); }) @@ -81,12 +81,12 @@ public function test_belongs_to_field_should_ignore_query_parameters_when_editin 'viaRelationship' => 'posts', ])) ->waitForTextIn('h1', 'Update User Post: '.$post->id) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Users') ->assertSeeLink('User Details: James Brooks') ->assertCurrentPageTitle('Update User Post'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertSelectedSearchResult('users', 'Taylor Otwell'); }) ->assertMissing('@users-unlock-relation'); diff --git a/tests/Browser/UpdateWithMorphToTest.php b/tests/Browser/UpdateWithMorphToTest.php index 1430c80b..06a6702a 100755 --- a/tests/Browser/UpdateWithMorphToTest.php +++ b/tests/Browser/UpdateWithMorphToTest.php @@ -48,12 +48,12 @@ public function test_resource_can_be_updated_to_new_parent_using_searchable() $browser->loginAs(1) ->visit(new Update('comments', $comment->id)) - ->within(new BreadcrumbComponent(), function ($browser) use ($comment) { + ->within(new BreadcrumbComponent, function ($browser) use ($comment) { $browser->assertSeeLink('Comments') ->assertSeeLink('Comment Details: '.$comment->id) ->assertCurrentPageTitle('Update Comment'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertMissing('@commentable-unlock-relation') ->searchFirstRelation('commentable', 2) ->assertMissing('@commentable-unlock-relation'); @@ -100,12 +100,12 @@ public function test_morph_to_field_should_honor_custom_polymorphic_type_using_s $browser->loginAs(1) ->visit(new Update('comments', $comment->id)) - ->within(new BreadcrumbComponent(), function ($browser) use ($comment) { + ->within(new BreadcrumbComponent, function ($browser) use ($comment) { $browser->assertSeeLink('Comments') ->assertSeeLink('Comment Details: '.$comment->id) ->assertCurrentPageTitle('Update Comment'); }) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->assertEnabled('select[dusk="commentable-type"]') ->within('select[dusk="commentable-type"]', function ($browser) { $browser->assertSee('Link'); @@ -177,11 +177,11 @@ public function test_morph_to_field_should_ignore_query_parameters_when_editing_ 'viaResourceId' => $post->id, 'viaRelationship' => 'comments', ])) - ->within(new BreadcrumbComponent(), function ($browser) { + ->within(new BreadcrumbComponent, function ($browser) { $browser->assertSeeLink('Link Details: 1') ->assertCurrentPageTitle('Update Comment'); }) - ->within(new FormComponent(), function ($browser) use ($post) { + ->within(new FormComponent, function ($browser) use ($post) { $browser->whenAvailable('select[dusk="commentable-type"]', function ($browser) { $browser->assertEnabled('') ->assertSelected('', 'posts'); @@ -224,7 +224,7 @@ public function test_morph_to_fields_can_be_set_to_null() $browser->loginAs(1) ->visit(new Update('photos', $photo->id)) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->selectRelation('imageable', ''); })->update() ->waitForText('The photo was updated!'); diff --git a/tests/Browser/VisitPreviousPageRedirectionTest.php b/tests/Browser/VisitPreviousPageRedirectionTest.php index cd660f64..1a0e341c 100644 --- a/tests/Browser/VisitPreviousPageRedirectionTest.php +++ b/tests/Browser/VisitPreviousPageRedirectionTest.php @@ -64,7 +64,7 @@ public function test_it_can_redirect_to_correct_page_after_continue_updating() $browser->waitForTable() ->editResourceById($category->getKey()); })->on(new Update('categories', $category->getKey())) - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', 'Laravel'); }) ->updateAndContinueEditing() @@ -92,7 +92,7 @@ public function test_it_can_redirect_to_correct_parent_page_after_creating_anoth ->assertQueryStringHas('viaResourceId', $category->getKey()) ->assertQueryStringHas('viaRelationship', 'subcategories') ->assertQueryStringHas('relationshipType', 'hasMany') - ->within(new FormComponent(), function ($browser) { + ->within(new FormComponent, function ($browser) { $browser->type('@name', 'Laravel'); }) ->createAndAddAnother()