add stricter type return to Model::getKey #53287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
treyssatvincent
force-pushed
the
treyssatvincent-patch-1
branch
from
b9fbd73
to
1fe8675
Compare
Indeed, it has a breaking change because it changes the return type of a method in the I could change only |
|
My bad, I didn't realized that it could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that
getKeycan only returns aintor astringas I don't think it's supported to have something else as primary key.The aim is to improve type hinting when this method is used.
I didn't used the PHPDoc: it's suggested in https://laravel.com/docs/11.x/contributions#phpdoc to use native types in signature but most the methods on that class uses PHPDoc so I'm not sure about it.