Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Strip token from config options when making new AWS (DynamoDB) clients #48283

Closed
wants to merge 1 commit into from

Conversation

mmehmet
Copy link
Contributor

@mmehmet mmehmet commented Sep 4, 2023

  • strip token from config options on DynamoDB clients
  • only strip token for now

@driesvints driesvints changed the title Strip token from config options when making new AWS (DynamoDB) clients [10.x] Strip token from config options when making new AWS (DynamoDB) clients Sep 4, 2023
@driesvints
Copy link
Member

This will need a much more thorough explanation why this is needed.

@mmehmet
Copy link
Contributor Author

mmehmet commented Sep 4, 2023

@driesvints this fixes the same issue that was mentioned here - using a similar fix to that PR, which strips out the token element from the config

this has been an issue when using recent versions of the AWS PHP SDK (as mentioned in this issue) - such as when attempting to use DynamoDB with an "out of the box" Laravel

unfortunately that PR does not also fix the issue for the CacheManager - which is also affected by the same problem with the config, when creating a new DynamoDB client - hence this PR

@joedixon
Copy link
Contributor

joedixon commented Sep 4, 2023

Hey @mmehmet, I'm not sure how token is ever present in the top level of the $dynamoConfig array.

As far as I can see, that variable is created in the method and the token key is never set.

@mmehmet
Copy link
Contributor Author

mmehmet commented Sep 4, 2023

@joedixon you're right - it needs to be stripped from the 'credentials` array element - I will make a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants