Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract styles/components from reused classes? #21

Open
imliam opened this issue May 9, 2020 · 1 comment
Open

Extract styles/components from reused classes? #21

imliam opened this issue May 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@imliam
Copy link
Contributor

imliam commented May 9, 2020

I figured I'd raise this as a discussion point to see what people think so we can come to a consensus before raising anything.

Right now we've got a handful of CSS classes we re-use all over the auth views, in particular for things like <button> styles. In most real applications, I'd personally see this as something I need to commonly reuse, and I'd extract it to either a Blade component <x-button> or CSS class .button

That said, the buttons we have so far are not typical buttons you'd find in an app - there's no primary/secondary/danger/etc. styles and it's not guaranteed people will use these styles again as the button is specifically styled for the auth pages.

Thoughts?

@imliam imliam added the enhancement New feature or request label May 9, 2020
@jeffgreco13
Copy link

Hi @imliam. I've done essentially this on my latest build which started with this TALL Preset. Would you like me to submit a PR?

I've extracted components for x-button, x-input, x-label and x-input.checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants