support WindowEvent::DroppedFile #524
Conversation
src/window_handle.rs
Outdated
| pub(crate) fn dropped_file(&mut self, path: PathBuf) { | ||
| self.dropper_file = Some(path.clone()); | ||
| self.event(Event::DroppedFile(DroppedFileEvent { path })); | ||
| } | ||
|
|
||
| pub(crate) fn pointer_move(&mut self, pos: Point) { | ||
| if let Some(path) = self.dropper_file.take() { | ||
| self.event(Event::DroppedFileWithPosition( | ||
| DroppedFileWithPositionEvent { path, pos }, | ||
| )); | ||
| } |
There was a problem hiding this comment.
The cursor position is stored in self.cursor_position. So we should be able to send the dropped file event with the cursor position when the dropped file event was trigger from winit.
There was a problem hiding this comment.
I tried. It's not accurate. The mouse coordinates are not updated when you drag and drop
There was a problem hiding this comment.
Yeah it's something at winit's end. It should be fixed when this is implemented rust-windowing/winit#3833
Does it always emit pointer move after the file was dropped? If so, we don't need the drop file event without mouse position.
There was a problem hiding this comment.
yes, my observation is this.
There was a problem hiding this comment.
Shall we just have one event DroppedFile with both path and pos please?
There was a problem hiding this comment.
Well, I just kept DroppedFileWithPositionEvent
|
rename |
No description provided.