Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement]: more precise CheckMem function #306

Closed
wants to merge 1 commit into from

Conversation

broccoliSpicy
Copy link
Contributor

@Ngalstyan4
Copy link
Contributor

Thanks for the PR @broccoliSpicy!
Scalar quantization is not yet supported for lantern_hnsw indexes So this is not urgent right now - the assumption of float arrays holds for all code paths rn.

Something like this will be added once we add quantization support

@Ngalstyan4 Ngalstyan4 closed this Apr 4, 2024
@broccoliSpicy
Copy link
Contributor Author

Gotcha, I felt the codebase right now is not that fit for tackling existing issues so I did this PR.

is it cool if Lantern publish more issues or feature requests for the community to tackle?

@Ngalstyan4
Copy link
Contributor

Please do!
If possible, please also share your use cases and usage details whenever relevant for the issues you open.

@broccoliSpicy
Copy link
Contributor Author

broccoliSpicy commented Apr 5, 2024

Please do! If possible, please also share your use cases and usage details whenever relevant for the issues you open.

haha, sorry, I didn't state it clearly, I was trying to say if there are some features, perhaps on Lantern's roadmap, that is suitable now for community contributors to work on

@Ngalstyan4
Copy link
Contributor

If you are familiar with CPP allocator patterns, #147 might be a good one.
I just created another issue (#308) and we would love to see contributions on that as well.

@broccoliSpicy
Copy link
Contributor Author

Thanks so much!
I will definitely try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants