Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted QR_WIFI_PASSWORD is too long to show #48

Open
Gloomyeye opened this issue Jul 24, 2024 · 3 comments
Open

Inserted QR_WIFI_PASSWORD is too long to show #48

Gloomyeye opened this issue Jul 24, 2024 · 3 comments

Comments

@Gloomyeye
Copy link

Hello,

thank you for your great project and your effort.
If I try to see the QR_WIFI_PASSWORD (17 characters long) I have entered, I have to realize that it is displayed over the edge of the display and extends into the QR code. The password is not readble as well as the qr code is can not be used correctly. Unfortunately, I don't see any way to change the font size of the password so that the password can be displayed correctly. It is possible to add this feature inside the config.h? Alternatively, it is possible to add a logic which counts the characters and decrease the font size automatically.

Thank you!

@lanrat
Copy link
Owner

lanrat commented Aug 1, 2024

There is existing code in https://github.com/lanrat/homeplate/blob/main/src/message.cpp#L27 that dynamically adjusts the font size so that a message can fit within the display area. It currently is only used by the message activity, and only for text that takes up the entire screen.

I don't think it would be too much work to modify it to take a variable screen area as an additional input and use it for the wifi activity as well.

I would welcome a PR with this enhancement if you or anyone else wants to tackle it.

@Gloomyeye
Copy link
Author

Thank you for your hints. However, I am not familiar with C or C++. I could test the changes if someone handle this.

@Gloomyeye
Copy link
Author

@pimlie: I notice that you are active with fixing some bugs. Maybe you could help me with that bug. I would appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants