Cleanup testing of bml_add #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=====================================
- Coverage 50% 50% -1%
=====================================
Files 211 211
Lines 8107 8107
Branches 788 788
=====================================
- Hits 4093 4092 -1
Misses 3897 3897
- Partials 117 118 +1
Continue to review full report at Codecov.
|
nicolasbock
force-pushed
the
cleanup_test_add
branch
from
ff19607
to
439c4fe
Compare
The empty string is also allowed.
Since we don't care where the random matrix elements are stored, we can change the double nested loops over the matrix dimensions into one loop over all elements. This change increases the amount of work that can be split across the OpenMP thread pool and potentially aid in parallel performance.
We should test all APIs of `bml_add`. This change adds the missing API tests.
nicolasbock
force-pushed
the
cleanup_test_add
branch
from
439c4fe
to
4e2fe61
Compare
|
This PR is stale because it has been open for 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be testing all APIs of
bml_test. This change adds themissing API tests.
This change is