[fr] add exception for nouns in V.* tags - Update #10384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The German CI failed? o0 My change doesn't change that part. |
Sharcoux
force-pushed
the
add-rule-verbe-plus-nom
branch
from
9748587
to
597423a
Compare
Sharcoux
changed the title
Sharcoux
force-pushed
the
add-rule-verbe-plus-nom
branch
from
597423a
to
b2b13ee
Compare
|
@jaumeortola I updated the description of this one too, added some examples and updated the title of the PR to match the patterns. If the CI succeeds, I think that it can be merged too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update based on the comments here: #9875
Basically,
postag="V.*"was matching Nouns as well, so I added an exception to remove those from the detection.For instance: