-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crimean Tatar (crh) #10026
Crimean Tatar (crh) #10026
Conversation
...nguage-modules/crh/src/main/java/org/languagetool/synthesis/crh/CrimeanTatarSynthesizer.java
Outdated
Show resolved
Hide resolved
...etool-language-modules/crh/src/main/resources/org/languagetool/resource/crh/dev/build.gradle
Show resolved
Hide resolved
|
So (at least for now) crh dictionary contains words duplicated in Latin and Cyrillic, so we have 10k + 10k words. If we should trim it to 10k total, I can cut it to 5k + 5k |
@danielnaber based on what you said about common_words, it could be that in this (unique) case with two alphabets it makes sense for 10k+10k, as the text would be either in Latin or Cyrillic and in each case only 10k of either set of words would be in play. So this would work in the algorithm is based on absolute values. Unless I am missing something. |
I guess 10k+10k would be okay |
I guess this is ready to be merged now? Just as a heads-up: while I can merge this, please don't expect the language to show up in the UI. Adapting the UIs is a lot of manual work, and adding one more language makes the usability of the long drop-down even worse. |
Yes, thank you. The team understands it'll take some time to reach the UI. |
Add Crimean Tatar Language (crh)