Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add svg render & Image preview optimization #8387

Merged
merged 9 commits into from
Sep 14, 2024

Conversation

charli117
Copy link
Contributor

@charli117 charli117 commented Sep 13, 2024

Checklist:

Added front-end SVG image rendering and optimized image preview operations

svg.rendering.mp4

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #8431

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 13, 2024
@dosubot dosubot bot added javascript Pull requests that update Javascript code 💪 enhancement New feature or request labels Sep 13, 2024
@sfyumi
Copy link

sfyumi commented Sep 14, 2024

This feature really helps me a lot. Hoping to merge into the main branch soon.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 14, 2024
@crazywoola crazywoola merged commit 445497c into langgenius:main Sep 14, 2024
3 checks passed
@charli117 charli117 deleted the svg-message-rendering branch September 14, 2024 16:27
@charli117 charli117 restored the svg-message-rendering branch September 14, 2024 16:28
@charli117 charli117 deleted the svg-message-rendering branch September 14, 2024 16:28
LLmoskk pushed a commit to LLmoskk/dify that referenced this pull request Sep 16, 2024
hos715 pushed a commit to hos715/dify that referenced this pull request Sep 16, 2024
hos715 pushed a commit to hos715/dify that referenced this pull request Sep 16, 2024
laipz8200 pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render HTML tag in conversation of LLM output
3 participants