Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given publish means something different on the CLI, shall we remove or rename it? #213

Open
falexwolf opened this issue Jul 24, 2022 · 2 comments

Comments

@falexwolf
Copy link
Member

falexwolf commented Jul 24, 2022

I'm not sure whether "publish()" is even needed on the CLI. I'm rather against it.

What is the current rationale for keeping it around? I know the original motivation became moot given that we print the pypackage store also for drafts.

parser_publish = subparsers.add_parser("publish", help="pubish the notebooks")
parser_publish.add_argument("files_dirs", nargs="+", help="publish these notebooks")

@Koncopd
Copy link
Member

Koncopd commented Jul 24, 2022

I think it is still kind of more convenient to publish from CLI if you use classic jupyter notebooks.

@falexwolf
Copy link
Member Author

That's OK - but do you want to rename it given it means something else? Which features of publish does it entail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants