Add Support for PHP 8.4

[nishant04412]

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

Description

[W0rma]

Seems like the PHP 8.4 pipeline is blocked by laminas/laminas-stdlib#118

[nishant04412]

Yes and laminas/laminas-stdlib#118 looks to be blocked due to vimeo/psalm#10928

I added a comment laminas/laminas-stdlib#118 (comment) to confirm same. Lets hope dependent PRs get merged soon to unblock this.

[nishant04412]

@gsteel I am facing some issues while resolving one of the issue in

laminas-code/test/Generator/TestAsset/ParameterClass.php

Line 78 in 562e02b

public function defaultObjectEqualsNullAndNotOptional(\stdClass $a = null, $b)

Here, if we add ? before \stdClass $a = null then it'll resolve PHP 8.4 related issue but then test is giving deprecation Optional parameter $a declared before required parameter $b is implicitly treated as a required parameter.

Please suggest if we can keep mandatory parameter $b before optional parameter $a in this ? Or any other advise if not.

[gsteel]

Please suggest if we can keep mandatory parameter $b before optional parameter $a in this ? Or any other advise if not.

$a is effectively mandatory because $b is and we don't support BC on named parameters, so the signature can be changed to fn(stdClass|null $a, $b) without breaking BC AFAIC. Alternatively, retain the = null and just suppress the CS issue.

Also, this is a Test asset - BC is not a concern.

[samsonasik]

default null value can be removed if next parameter is required, see

https://3v4l.org/4pQLN

that safe even extended, also, named argument is not used in the test :)

[nishant04412]

@samsonasik Please review and let me know if clarification or code modification required.

[samsonasik]

Sign off is needed, read https://github.com/laminas/laminas-code/pull/201/checks?check_run_id=32024385175

[nishant04412]

@gsteel PR changes are approved. Can you please check and merge this PR ?

[gsteel]

Thank you @nishant04412