We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the L1 contracts, we are currently sending msg.value AND the _amount field with the same values to catch both native token and native eth cases.
msg.value
_amount
Use the preprocessor to add checks: In the case of native ERC20: msg.value should be zero. In the case of native ETH: _amount should be zero.
Most of this changes should be done in Mailbox.sol and the bridges.
The text was updated successfully, but these errors were encountered:
SantiagoPittella
No branches or pull requests
🌟 Feature Request
📝 Description
In the L1 contracts, we are currently sending
msg.value
AND the_amount
field with the same values to catch both native token and native eth cases.Use the preprocessor to add checks:
In the case of native ERC20:
msg.value
should be zero.In the case of native ETH:
_amount
should be zero.📋 Additional Context
Most of this changes should be done in Mailbox.sol and the bridges.
The text was updated successfully, but these errors were encountered: