Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create state dump even if unexpected error occurs #72

Open
JulianGCalderon opened this issue Oct 21, 2024 · 0 comments · May be fixed by #86
Open

Create state dump even if unexpected error occurs #72

JulianGCalderon opened this issue Oct 21, 2024 · 0 comments · May be fixed by #86

Comments

@JulianGCalderon
Copy link
Contributor

If a transaction fails unexpectedly, then a state dump is not generated:

Err(error_reason) => {
error!("execution failed unexpectedly: {}", error_reason);
return;
}

If native fails unexpectedly while the VM does not, then the delta_state_dumps.sh script will not detect this (as one of the files is missing).

I think we should create a file anyway, containing the error message, just so that there is a file to compare with. This can help find easy-to-miss errors.

@JulianGCalderon JulianGCalderon linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant