Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Winterfell AIR Adapter for field extensions #720

Merged
merged 32 commits into from
Dec 20, 2023

Conversation

schouhy
Copy link
Contributor

@schouhy schouhy commented Dec 14, 2023

Update Winterfell AIR Adapter for field extensions

Description

This PR modifies the winterfell AIR adapter to support field extensions. It also:

  • Implements IsSubFieldOf<QuadFelt> for Felt, where QuadFelt and Felt are winterfell's field elements.
  • Tests and benchmarks that use lambdaworks prover to prove miden_vm are modified to use the quadratic extension.

This PR depends on #717 and should be merged after it.

Type of change

  • New feature

Checklist

  • Unit tests added

@schouhy schouhy requested review from ajgara and a team as code owners December 14, 2023 15:10
@schouhy schouhy marked this pull request as draft December 14, 2023 15:11
MauroToscano
MauroToscano previously approved these changes Dec 20, 2023
@schouhy schouhy marked this pull request as ready for review December 20, 2023 17:49
@entropidelic entropidelic added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit f857a3a Dec 20, 2023
7 checks passed
@entropidelic entropidelic deleted the update-winterfell-adapter-for-field-extensions branch December 20, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants