Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): de/serialization for Transaction #1069

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix(core): de/serialization for Transaction #1069

merged 2 commits into from
Nov 5, 2024

Conversation

fborello-lambda
Copy link
Contributor

@fborello-lambda fborello-lambda commented Nov 5, 2024 •
edited
Loading

Motivation

The Transaction enum had the Deserialize trait derived, but it wasn't working. A custom Deserialize trait needs to be derived and match by transaction.

Description

  • A custom Deserialize impl is defined for the Transaction enum.
  • A test that Serializes a Transaction and then Deserialized it is provided, taking an EIP1559 as example.

@fborello-lambda fborello-lambda self-assigned this Nov 5, 2024
@fborello-lambda fborello-lambda marked this pull request as ready for review November 5, 2024 13:21
@fborello-lambda fborello-lambda requested a review from a team as a code owner November 5, 2024 13:21
@jrchatruc jrchatruc added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 0246227 Nov 5, 2024
13 checks passed
@jrchatruc jrchatruc deleted the fix/tx_de_serialization branch November 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@fborello-lambda fborello-lambda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fborello-lambda @jrchatruc