Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l2): wallet transfer #1022

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(l2): wallet transfer #1022

merged 1 commit into from
Oct 30, 2024

Conversation

ilitteri
Copy link
Contributor

Motivation

Transfer transactions were being prepared wrongly. The max_fee_per_gas, nonce, and chain_id were picked from the eth_client without taking into account the l1 flag.

Description

Define the client to use at the top of the wallet transfer cmd handler to avoid using the wrong one later.

@ilitteri ilitteri added this to the [L2] 1 - Basic L2 milestone Oct 30, 2024
@ilitteri ilitteri self-assigned this Oct 30, 2024
@ilitteri ilitteri requested a review from a team as a code owner October 30, 2024 17:44
ManuelBilbao
ManuelBilbao approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManuelBilbao ManuelBilbao added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 66f1d1b Oct 30, 2024
12 checks passed
@ManuelBilbao ManuelBilbao deleted the fix_l2_cli_transfer branch October 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelBilbao ManuelBilbao ManuelBilbao approved these changes

Assignees

@ilitteri ilitteri

Labels
CLI L2
Projects
ethereum_rust_l2
Status: Done
Milestone
[L2] 1 - Basic L2
Development

Successfully merging this pull request may close these issues.
2 participants
@ilitteri @ManuelBilbao