-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doctests #764
Comments
hey @igaray can I work on this one? It would probably take me around a day to upload a PR for this |
Hey Adrian! sure, go ahead.
I would say take a look at that PR and see if you want to start, and open a draft PR on which we can talk and guide you. Don't try to have at it in one go to make sure you don't waste effort. In addition, if while reading the docs something is not clear, then please ask questions. A fresh set of eyes reading the docs and asking questions is very valuable. Thanks |
@igaray sounds good, I will do as you say and make sure to stay in contact |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI am a passionate and results-driven web developer, currently deepening my knowledge in web3 technologies, Cairo, and open-source development through Dojo Coding. My skill set includes expertise in JavaScript, React, HTML, CSS, C# with .NET Entity Framework, and more. I also have experience with tools like Git, GitHub, SQL Server, and Postman. My focus has been on building solid web applications, from task lists to full-fledged CRUD systems, with front-end, back-end, and database integration. This will be my first contribution to the open-source ecosystem, and I am excited to learn and collaborate on innovative projects, particularly those involving Cairo. How I plan on tackling this issueTo address the issue of code examples with the ignore attribute, first review all examples in Markdown files and code documentation to determine their relevance and necessity. Next, classify the examples into two categories: those that should retain the ignore attribute due to specific requirements and those that are outdated and need to be either removed or updated. Change the ignore attribute to should_panic where appropriate and remove examples that no longer provide value. Finally, ensure that all code examples are executable and that the documentation accurately reflects the updates. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI'm a blockchain developer honing skills from past 3 years How I plan on tackling this issueMy approach would be :
|
Hi @igaray i will love to work on this |
Hello everyone! @adrianvrj @kunalrosaili05 @ShantelPeters @ScottyDavies |
Hi @igaray I am aware, I actually did not see the issue on OD 😅 |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI am a blockchain and DeFi developer . I am having experience of 8 months . I am currently working as a Blockchain Researcher and Developer. My Experience in programming language like Go , Rust , Java will help me to solve this issue. |
All the code examples in the documentation have the
ignore
attribute set. Some of them truly require it while others have gone stale as a result. All the code examples in the markdown files in thedocs
folder, as well as the in the in-code documentation, should be checked, have theignore
attribute changed tono_run
, 'should_panic`, or removed to ensure that examples are correct.See https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html#attributes for reference.
The text was updated successfully, but these errors were encountered: