Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deps for fuzzing #1432

Merged
merged 7 commits into from
Sep 4, 2023
Merged

Fix deps for fuzzing #1432

merged 7 commits into from
Sep 4, 2023

Conversation

Juan-M-V
Copy link
Contributor

@Juan-M-V Juan-M-V commented Sep 1, 2023 •
edited
Loading

Fix deps imports for fuzzing to work

Description

Fix arbitrary feature imports and impl. Depends on lambdaclass/types-rs#3

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Juan-M-V Juan-M-V marked this pull request as draft September 1, 2023 13:39
@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.113 ± 0.007 3.103 3.129 1.00 ± 0.00
head big_factorial 3.106 ± 0.009 3.096 3.123 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.045 ± 0.006 3.038 3.058 1.00 ± 0.01
head big_fibonacci 3.035 ± 0.019 3.024 3.087 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.754 ± 0.110 9.655 9.967 1.00 ± 0.01
head blake2s_integration_benchmark 9.714 ± 0.041 9.676 9.790 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.199 ± 0.007 3.189 3.214 1.00
head compare_arrays_200000 3.201 ± 0.006 3.194 3.215 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.063 ± 0.004 2.057 2.074 1.00 ± 0.00
head dict_integration_benchmark 2.060 ± 0.004 2.054 2.067 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.585 ± 0.007 1.578 1.597 1.00
head field_arithmetic_get_square_benchmark 1.585 ± 0.005 1.578 1.597 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.731 ± 0.039 9.684 9.796 1.00
head integration_builtins 9.796 ± 0.189 9.676 10.274 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.984 ± 0.032 9.944 10.023 1.00
head keccak_integration_benchmark 9.989 ± 0.047 9.929 10.052 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.235 ± 0.071 3.190 3.436 1.01 ± 0.02
head linear_search 3.194 ± 0.007 3.189 3.211 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.299 ± 0.009 2.287 2.313 1.00
head math_cmp_and_pow_integration_benchmark 2.313 ± 0.004 2.309 2.322 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.198 ± 0.005 2.191 2.206 1.01 ± 0.01
head math_integration_benchmark 2.174 ± 0.010 2.163 2.190 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.816 ± 0.012 1.809 1.849 1.00
head memory_integration_benchmark 1.838 ± 0.004 1.835 1.847 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.328 ± 0.011 2.316 2.356 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.325 ± 0.005 2.319 2.335 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 789.6 ± 0.5 788.6 790.2 1.00
head pedersen 790.0 ± 2.6 785.3 795.2 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.318 ± 0.003 1.312 1.322 1.00 ± 0.01
head poseidon_integration_benchmark 1.315 ± 0.006 1.309 1.329 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.538 ± 0.006 2.529 2.548 1.00
head secp_integration_benchmark 2.539 ± 0.012 2.531 2.572 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.347 ± 0.002 1.346 1.351 1.00 ± 0.00
head set_integration_benchmark 1.345 ± 0.002 1.343 1.349 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.961 ± 0.029 5.942 6.034 1.00
head uint256_integration_benchmark 5.963 ± 0.027 5.942 6.029 1.00 ± 0.01

@pefontana pefontana marked this pull request as ready for review September 4, 2023 21:05
@pefontana pefontana merged commit 72ea3a5 into use-standard-felt Sep 4, 2023
27 of 39 checks passed
@pefontana pefontana deleted the fix-felt-arbitrary-dep-fuzzer branch September 4, 2023 21:06
github-merge-queue bot pushed a commit that referenced this pull request Dec 21, 2023
@pefontana @fmoletta
@Juan-M-V @Oppen @edg-l
Use starknet-types-core Felt (#1408)
fe72ee0 
* Initial swap

* Misc changes

* Misc changes

* Add felt_to_biguint util

* Misc changes

* Move to_signed_felt to math_utils

* Fix code

* Fix code

* Fix code

* Remove felt crate

* Remove felt crate

* Restore felt_str macro + other changes

* Fix parsing utils

* Add changes

* Add changes

* Add fixes

* Add fixes

* Add fixes

* Add fixes

* Fix maybe_add_padding

* Pad bytes in keccak hints

* Fix bigint to felt conversion

* Restore tests

* Fix test

* Fix recover_y

* Fix biguint to felt conversion

* Fix is_addr_bounded hint

* Fix test

* Make safe_div safe again

* Fix negative number parsing in felt_str

* Revert "Fix negative number parsing in felt_str"

This reverts commit 3feb9a2.

* Remove negative handling in deserialization util

* Fix byte conversions in keccak auto-deduction

* Update felt commit

* Remove felt crate

* Fix EC OP tests

* Fix sqrt

* Fix unsafe keccak hints

* fix keccak integration test

* Fix deserialize_scientific_notation

* Fix error when deserializing big numbers

* cargo clippy

* fix merge main changes

* Improve  Add<&Felt252> for Relocatable

* Indicate type-rs commit

* Fix merge conflicts

* Update type-rs commit

* Fix wasm and hint accountant imports (#1436)

* Add import for string

* Cargo fmt

* Update air_public_input.rs

---------

Co-authored-by: juan.mv <[email protected]>

* Bump commit

* Fix felt display

* Fix deps for fuzzing (#1432)

* Fix deps for fuzzing

* Revert stark-felt import change

* Cargo fmt

* Merge use-felt

---------

Co-authored-by: juan.mv <[email protected]>

* cargo clippy

* fix  bench/criterion_benchmark.rs

* cargo clippy in fuzzer

* Remove lambdaworks-felt workflows

* Missed a spot

* Remove dep in ensure-no_std

* don't create an extra implicit feature (slows down build checks)

* air public memory is hex

* Remove old import

* Remove panic handler

* improve find_element_hint

* Restore MaybeRelocatable formatting

* stark-felt no-default-features

* more feature work

* Update types-rs

* Update RELEASE docs

* Update stark-felt, expect slowdown here

* Remove double import

* Clippy

* changelog

* fix fuzzer

* cargo.lock

* Faster split

* faster bitwise

* clippy

* clippy

* Use vec of powers of 2

* address comments

* remove special features

* Apply suggestion

Co-authored-by: fmoletta <[email protected]>

* add todo

* fix build

* unwrap_or_default

* nostd

* clippy

* typo codecov cache

* codecov cache typo

* Update type-rs commit

* Update fuzzer/Cargo.lock

* Use starknet-types-core to 0.0.3 v

* Empty-Commit

* Empty-Commit

* Update starknet-types-core version

* n_elms_iter: u32

* fix warnings

* Include extensive-hints in coverage

* fix stuff

* Update Changelog

* Update Changelog

---------

Co-authored-by: Federica <[email protected]>
Co-authored-by: Juan-M-V <[email protected]>
Co-authored-by: juan.mv <[email protected]>
Co-authored-by: Mario Rugiero <[email protected]>
Co-authored-by: Mario Rugiero <[email protected]>
Co-authored-by: fmoletta <[email protected]>
Co-authored-by: Edgar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igaray igaray Awaiting requested review from igaray

@Oppen Oppen Awaiting requested review from Oppen

@fmoletta fmoletta Awaiting requested review from fmoletta

@entropidelic entropidelic Awaiting requested review from entropidelic

@juanbono juanbono Awaiting requested review from juanbono

@pefontana pefontana Awaiting requested review from pefontana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juan-M-V @pefontana