Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix python build condition in build_programs job CI #1397

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Aug 23, 2023

The build_programs job checks for cache hits & program-target to decide if it shoud setup python. This job currently checks that the cache hasn't been hit and the program-target is not cairo_1_test_contracts, it should also check that the program-target is not cairo_2_test_contracts either

@fmoletta fmoletta added pipelines This PR/issue is exclusively about improving our CI high-priority labels Aug 23, 2023
@fmoletta fmoletta marked this pull request as ready for review August 23, 2023 21:43
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1397 (407d176) into main (2d214f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          94       94           
  Lines       38485    38485           
=======================================
  Hits        37528    37528           
  Misses        957      957           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 5.030 ± 0.105 4.880 5.210 1.00
head big_factorial 5.046 ± 0.023 5.001 5.086 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.273 ± 0.030 4.237 4.318 1.00
head big_fibonacci 4.347 ± 0.036 4.304 4.416 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 12.481 ± 0.085 12.374 12.689 1.01 ± 0.01
head blake2s_integration_benchmark 12.345 ± 0.050 12.259 12.434 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.348 ± 0.023 4.318 4.399 1.00
head compare_arrays_200000 4.385 ± 0.017 4.352 4.416 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.875 ± 0.039 2.836 2.974 1.00
head dict_integration_benchmark 2.890 ± 0.012 2.873 2.917 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.169 ± 0.019 2.151 2.218 1.00
head field_arithmetic_get_square_benchmark 2.191 ± 0.046 2.157 2.298 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.345 ± 0.117 12.199 12.624 1.00
head integration_builtins 12.408 ± 0.097 12.317 12.655 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 12.575 ± 0.153 12.334 12.878 1.02 ± 0.03
head keccak_integration_benchmark 12.376 ± 0.306 12.024 13.017 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.317 ± 0.083 4.226 4.488 1.02 ± 0.03
head linear_search 4.212 ± 0.092 4.115 4.415 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.147 ± 0.070 3.084 3.327 1.01 ± 0.03
head math_cmp_and_pow_integration_benchmark 3.129 ± 0.043 3.053 3.223 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.803 ± 0.013 2.772 2.813 1.00
head math_integration_benchmark 2.821 ± 0.015 2.806 2.848 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.465 ± 0.023 2.439 2.524 1.00
head memory_integration_benchmark 2.471 ± 0.017 2.448 2.513 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.776 ± 0.039 2.711 2.849 1.00 ± 0.02
head operations_with_data_structures_benchmarks 2.766 ± 0.053 2.712 2.857 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.013 ± 0.003 1.009 1.018 1.00
head pedersen 1.020 ± 0.004 1.014 1.026 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.814 ± 0.057 1.763 1.932 1.01 ± 0.04
head poseidon_integration_benchmark 1.789 ± 0.046 1.749 1.889 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.512 ± 0.042 3.454 3.585 1.00
head secp_integration_benchmark 3.540 ± 0.020 3.518 3.578 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.811 ± 0.044 1.777 1.921 1.01 ± 0.03
head set_integration_benchmark 1.787 ± 0.009 1.767 1.806 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.969 ± 0.077 7.910 8.162 1.00 ± 0.01
head uint256_integration_benchmark 7.965 ± 0.052 7.865 8.030 1.00

@pefontana pefontana added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit f6d45d6 Aug 23, 2023
40 of 41 checks passed
@pefontana pefontana deleted the fix-ci branch August 23, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants