Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lambdawork's UnsignedInteger.div_rem instead of converting to BigInt in Felt252.div_rem #1395

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Aug 23, 2023

This change requires no new tests / changelog
Closes #1321

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 5.124 ± 0.178 4.941 5.443 1.02 ± 0.04
head big_factorial 5.028 ± 0.076 4.931 5.137 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.237 ± 0.035 4.196 4.315 1.00
head big_fibonacci 4.352 ± 0.048 4.292 4.446 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 12.298 ± 0.097 12.139 12.439 1.00 ± 0.02
head blake2s_integration_benchmark 12.258 ± 0.256 11.984 12.800 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.382 ± 0.093 4.319 4.629 1.02 ± 0.02
head compare_arrays_200000 4.313 ± 0.023 4.271 4.355 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.906 ± 0.035 2.841 2.948 1.00
head dict_integration_benchmark 2.911 ± 0.019 2.867 2.936 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.120 ± 0.026 2.094 2.176 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 2.109 ± 0.009 2.087 2.118 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.112 ± 0.150 11.895 12.294 1.00
head integration_builtins 12.297 ± 0.047 12.231 12.368 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 12.590 ± 0.170 12.401 13.028 1.00 ± 0.02
head keccak_integration_benchmark 12.575 ± 0.108 12.482 12.818 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.414 ± 0.040 4.356 4.460 1.01 ± 0.01
head linear_search 4.381 ± 0.043 4.267 4.424 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.146 ± 0.037 3.076 3.217 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 3.123 ± 0.026 3.077 3.163 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.831 ± 0.053 2.756 2.902 1.01 ± 0.02
head math_integration_benchmark 2.806 ± 0.038 2.758 2.869 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.440 ± 0.020 2.415 2.485 1.00
head memory_integration_benchmark 2.481 ± 0.062 2.410 2.629 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.788 ± 0.067 2.718 2.965 1.00 ± 0.03
head operations_with_data_structures_benchmarks 2.779 ± 0.024 2.727 2.811 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.024 ± 0.020 0.993 1.055 1.00 ± 0.02
head pedersen 1.023 ± 0.011 0.993 1.033 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.773 ± 0.021 1.745 1.812 1.00
head poseidon_integration_benchmark 1.800 ± 0.013 1.780 1.821 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.540 ± 0.018 3.506 3.560 1.02 ± 0.01
head secp_integration_benchmark 3.480 ± 0.044 3.424 3.551 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.856 ± 0.011 1.841 1.871 1.00
head set_integration_benchmark 1.888 ± 0.055 1.860 2.041 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.110 ± 0.206 7.904 8.491 1.03 ± 0.03
head uint256_integration_benchmark 7.891 ± 0.072 7.826 8.046 1.00

@fmoletta fmoletta marked this pull request as ready for review August 23, 2023 21:25
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1395 (7237e4c) into main (4267138) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          94       94           
  Lines       38530    38540   +10     
=======================================
+ Hits        37571    37581   +10     
  Misses        959      959           
Files Changed Coverage Δ
felt/src/lib_lambdaworks.rs 97.90% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 112ccc9 Aug 29, 2023
38 checks passed
@pefontana pefontana deleted the use-lambdaworks-operations branch August 29, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use UnsignedInteger's division instead of BigUint's where possible
4 participants