Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.6.3 #1369

Merged
merged 10 commits into from
Aug 14, 2023
Merged

V0.6.3 #1369

merged 10 commits into from
Aug 14, 2023

Conversation

pefontana
Copy link
Member

V0.6.3

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

* fix bug

* Add test

* Add some checks to div_mod_floors of BigUints

* Update Changelog

* Remove unnecesarry zero check

* Remove unnecesarry zero check

* Remove unnecesary import
@pefontana pefontana changed the base branch from v0.6.2 to main August 11, 2023 16:35
@pefontana pefontana changed the base branch from main to branch-v0.6.2 August 11, 2023 16:36
@pefontana pefontana changed the base branch from branch-v0.6.2 to v0.6.2 August 11, 2023 16:41
@pefontana pefontana changed the base branch from v0.6.2 to releases/0.6.x August 11, 2023 16:43
@pefontana pefontana marked this pull request as ready for review August 11, 2023 16:45
@pefontana pefontana changed the base branch from releases/0.6.x to branch-v0.6.2 August 11, 2023 16:56
@pefontana pefontana changed the base branch from branch-v0.6.2 to releases/0.6.x August 11, 2023 16:58
This reverts commit 2184add.
@pefontana pefontana changed the base branch from releases/0.6.x to main August 11, 2023 19:52
@pefontana pefontana changed the base branch from main to releases/0.6.x August 11, 2023 19:52
@pefontana pefontana changed the base branch from releases/0.6.x to main August 11, 2023 19:55
@pefontana pefontana changed the base branch from main to releases/0.6.x August 11, 2023 19:56
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 14.302 ± 0.131 14.116 14.469 1.00
head blake2s_integration_benchmark 14.448 ± 0.162 14.201 14.701 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 5.126 ± 0.134 4.966 5.423 1.03 ± 0.03
head compare_arrays_200000 4.987 ± 0.038 4.921 5.034 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.347 ± 0.028 3.317 3.403 1.01 ± 0.01
head dict_integration_benchmark 3.327 ± 0.021 3.300 3.373 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.398 ± 0.082 5.330 5.620 1.01 ± 0.02
head factorial_multirun 5.371 ± 0.030 5.314 5.417 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.550 ± 0.051 4.490 4.624 1.01 ± 0.01
head fibonacci_1000_multirun 4.515 ± 0.029 4.471 4.573 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.347 ± 0.021 2.308 2.380 1.00
head field_arithmetic_get_square_benchmark 2.357 ± 0.022 2.323 2.397 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.669 ± 0.082 12.564 12.776 1.00 ± 0.01
head integration_builtins 12.647 ± 0.091 12.547 12.810 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 14.631 ± 0.162 14.402 14.999 1.01 ± 0.01
head keccak_integration_benchmark 14.461 ± 0.134 14.226 14.595 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.994 ± 0.038 4.943 5.063 1.01 ± 0.01
head linear_search 4.935 ± 0.050 4.861 5.018 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.482 ± 0.040 3.435 3.567 1.02 ± 0.02
head math_cmp_and_pow_integration_benchmark 3.430 ± 0.034 3.378 3.485 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.235 ± 0.047 3.160 3.338 1.01 ± 0.02
head math_integration_benchmark 3.204 ± 0.026 3.170 3.246 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.870 ± 0.022 2.835 2.909 1.02 ± 0.01
head memory_integration_benchmark 2.819 ± 0.026 2.779 2.866 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.106 ± 0.020 3.071 3.133 1.00
head operations_with_data_structures_benchmarks 3.108 ± 0.027 3.066 3.147 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.127 ± 0.020 1.108 1.162 1.01 ± 0.02
head pedersen 1.119 ± 0.013 1.103 1.144 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.967 ± 0.024 1.934 2.004 1.01 ± 0.01
head poseidon_integration_benchmark 1.954 ± 0.015 1.942 1.992 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.870 ± 0.055 3.796 3.977 1.01 ± 0.02
head secp_integration_benchmark 3.845 ± 0.052 3.757 3.940 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.176 ± 0.013 2.156 2.200 1.00
head set_integration_benchmark 2.222 ± 0.034 2.191 2.309 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.824 ± 0.077 8.687 8.937 1.00 ± 0.01
head uint256_integration_benchmark 8.781 ± 0.070 8.692 8.903 1.00

@MegaRedHand
Copy link
Contributor

Cherry-picking 9932cba might solve the issue

MegaRedHand and others added 3 commits August 14, 2023 14:25
The benchmarks consume a lot of memory.
Since we disabled swap memory usage, the bench runs fail sporadically because of OOM errors.
This makes them run with 1 process instead of 2 in parallel.
This reverts commit f10a7cf.
@pefontana
Copy link
Member Author

Cherry-picking 9932cba might solve the issue

thanks @MegaRedHand !

@pefontana pefontana merged commit 86687ec into releases/0.6.x Aug 14, 2023
29 of 30 checks passed
@pefontana pefontana deleted the v0.6.3 branch August 14, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants