Skip to content

Commit

Permalink
fix: make MemorySegmentManager.finalize() public (#1771)
Browse files Browse the repository at this point in the history
* fix: make MemorySegmentsManager.finalize() public

This method is used in some of the bootloader hints.

* changelog
  • Loading branch information
odesenfans committed May 23, 2024
1 parent f4a2214 commit a30e5c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: make MemorySegmentManager.finalize() public [#1771](https://github.com/lambdaclass/cairo-vm/pull/1771)

* feat(BREAKING): Serialize `Array<Felt252>` return value into output segment in cairo1-run crate:
* Checks that only `PanicResult<Array<Felt252>>` or `Array<Felt252>` can be returned by the program when running with either `--proof_mode` or `--append_return_values`.
* Serializes return values into the output segment under the previous conditions following the format:
Expand Down
2 changes: 1 addition & 1 deletion vm/src/vm/vm_memory/memory_segments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ impl MemorySegmentManager {
// * size - The size of the segment (to be used in relocate_segments).
// * public_memory - A list of offsets for memory cells that will be considered as public
// memory.
pub(crate) fn finalize(
pub fn finalize(
&mut self,
size: Option<usize>,
segment_index: usize,
Expand Down

0 comments on commit a30e5c8

Please sign in to comment.