Skip to content

Commit

Permalink
Serialize directly into writer in CairoPie::write_zip_file (#1736)
Browse files Browse the repository at this point in the history
* Write directly to writer

* Impl Serialize & Deserialize for CairoPieMemory

* Revert "Impl Serialize & Deserialize for CairoPieMemory"

This reverts commit 3477b1c.

* Fix

* Add changelog entry
  • Loading branch information
fmoletta committed Apr 25, 2024
1 parent 2e24b6a commit 789bef1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## Cairo-VM Changelog

#### Upcoming Changes

* Serialize directly into writer in `CairoPie::write_zip_file`[#1736](https://github.com/lambdaclass/cairo-vm/pull/1736)

* feat: Add support for cairo1 run with segements arena validation.
* Refactored the runner CASM code generation to user a more high level builder.
* Added segment merging of the dictionary segments.
Expand Down
8 changes: 4 additions & 4 deletions vm/src/vm/runners/cairo_pie.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,15 +254,15 @@ impl CairoPie {
let options =
zip::write::FileOptions::default().compression_method(zip::CompressionMethod::Deflated);
zip_writer.start_file("version.json", options)?;
zip_writer.write_all(serde_json::to_string(&self.version)?.as_bytes())?;
serde_json::to_writer(&mut zip_writer, &self.version)?;
zip_writer.start_file("metadata.json", options)?;
zip_writer.write_all(serde_json::to_string(&self.metadata)?.as_bytes())?;
serde_json::to_writer(&mut zip_writer, &self.metadata)?;
zip_writer.start_file("memory.bin", options)?;
zip_writer.write_all(&self.memory.to_bytes())?;
zip_writer.start_file("additional_data.json", options)?;
zip_writer.write_all(serde_json::to_string(&self.additional_data)?.as_bytes())?;
serde_json::to_writer(&mut zip_writer, &self.additional_data)?;
zip_writer.start_file("execution_resources.json", options)?;
zip_writer.write_all(serde_json::to_string(&self.execution_resources)?.as_bytes())?;
serde_json::to_writer(&mut zip_writer, &self.execution_resources)?;
zip_writer.finish()?;
Ok(())
}
Expand Down

0 comments on commit 789bef1

Please sign in to comment.