Skip to content

Commit

Permalink
Disable unnecessary features of zip (#1832)
Browse files Browse the repository at this point in the history
We've discovered that using the `cairo-vm` crate in our projects brings
in a lot of unnecessary dependencies and in the end leads to our binary
being linked with the `libbz2` library.

Turns out that neither of these is actually required and this happens
because the `zip` crate has a large number of features enabled by
default.

This change disables all `zip` features except `deflate` which the code
actually uses.
  • Loading branch information
kkovaacs committed Sep 3, 2024
1 parent 59953d2 commit 294a10b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 168 deletions.
170 changes: 3 additions & 167 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test_utils = ["std", "dep:arbitrary", "starknet-types-core/arbitrary", "starknet
extensive_hints = []

[dependencies]
zip = {version = "0.6.6", optional = true }
zip = {version = "0.6.6", optional = true, default-features = false, features = ["deflate"]}
num-bigint = { workspace = true }
rand = { workspace = true }
num-traits = { workspace = true }
Expand Down

0 comments on commit 294a10b

Please sign in to comment.