Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butt: force default title for live shows (automatically) #60

Open
gammaw opened this issue Apr 2, 2019 · 17 comments
Open

Butt: force default title for live shows (automatically) #60

gammaw opened this issue Apr 2, 2019 · 17 comments
Assignees
Labels

Comments

@gammaw
Copy link
Member

gammaw commented Apr 2, 2019

No description provided.

@gammaw gammaw added this to the 0.3 - stability release milestone Apr 2, 2019
@gammaw
Copy link
Member Author

gammaw commented Apr 10, 2019

@baxgas can you look at it? Have you ever used butt (see https://github.com/AzuraCast/azuracast.com/blob/master/StreamingSoftware.md)? Use dev server for tests.

@gammaw
Copy link
Member Author

gammaw commented Apr 12, 2019

@baxgas we could use the song name info (see picture) sent by butt to transfer the live show's subtitle (e.g., 'Noise 'n Roses' -> comes from DJ Streamer's Display Name set in Azuracast and 'Judit, Bertók etc.' -> comes from butt). The song name ("yo" in this example) is included in the JSON of the nowplaying interface.

image

@gammaw
Copy link
Member Author

gammaw commented Apr 13, 2019

f4464a2

@gammaw gammaw closed this as completed Apr 13, 2019
@gammaw
Copy link
Member Author

gammaw commented Apr 15, 2019

Bummer, it's not fully done yet: when a live DJ starts and didn't convey the subtitle yet (from Butt), the subtitle from the last song is being shown. Any idea?

Expected: empty string is shown until not connected.

Workaround until fix: quickly enter subtitle via Butt.

@gammaw gammaw reopened this Apr 15, 2019
@gammaw gammaw added the enhancement New feature or request label Jun 7, 2019
@gammaw gammaw changed the title Add title for live shows Enable empty title for live shows Jun 7, 2019
@gammaw
Copy link
Member Author

gammaw commented Jul 10, 2019

Update: AzuraCast/AzuraCast#1734

@gammaw
Copy link
Member Author

gammaw commented Sep 13, 2019

Update: AzuraCast/AzuraCast#1968

@gammaw
Copy link
Member Author

gammaw commented Jan 24, 2020

Workaround: can't we script Butt somehow to send update upon new connection?

@gammaw gammaw changed the title Enable empty title for live shows Force default title for live shows (automatically) Feb 1, 2020
@gammaw
Copy link
Member Author

gammaw commented Feb 1, 2020

No reaction from Azuracast (see issue) nor from Butt developer (emailed them). Decision: try to find the bug in Azuracast, fix it and create pull request

@gammaw gammaw changed the title Force default title for live shows (automatically) Butt: force default title for live shows (automatically) Feb 1, 2020
@gammaw gammaw added the bug Something isn't working label Feb 16, 2020
@gammaw
Copy link
Member Author

gammaw commented Feb 17, 2020

Update:

  • key principle (Liquidsoap): internal AzuraCast REST API is called upon live DJ lifecycle change.
  • key classes (AzuraCast repo): InternalController.php and NowPlaying.php.
  • two new comments posted in Azuracast thread.

@gammaw gammaw removed the enhancement New feature or request label Feb 17, 2020
@gammaw
Copy link
Member Author

gammaw commented Feb 18, 2020

Interesting news! I managed to send a metadata update HTTP request directly to the Icecast server (while live broadcasting from Butt). I simply used a browser (logged in to the Icecast admin page). This has the same effect as Butt would do it (via the song name change button). Azuracast is informed automatically and the change is visible in the admin page and is also updated in the nowplaying API (I didn't manage to figure out how this propagation works).

Workaround candidate for the issue: send HTTP request upon successful connectin in Liquidsoap. Liquidsoap has commands for sending HTTP requests.

@gammaw
Copy link
Member Author

gammaw commented Feb 19, 2020

Update: we don't need to go over HTTP, we can add metadata directly in Liquidsoap.

@gammaw
Copy link
Member Author

gammaw commented Feb 19, 2020

Status summed up here: AzuraCast/AzuraCast#1968 (comment)

@gammaw
Copy link
Member Author

gammaw commented Feb 25, 2020

Conlusion: it seems that there is no easy solution for this issue.

Background:

  • Problem with Liquidsoap: every time Butt connects, Liquidsoap resends the title of the song from the previous session.
  • Problem with Butt: every time Butt connects, it sends the last okayed sing title.

Fix idea (won't work): set default title (e.g., live) when a Butt client connects. This would be possible in the Liquidsoap config in the live_connected function (see here). Unfortunately, the metadata update by LS and Butt (see above) comes later and overwrites this.

Fix plan: see here.

@pvj @baxgas: maybe I don't see obvious solutions, do you have any idea how to solve this quick & dirty?

gammaw added a commit that referenced this issue Feb 26, 2020
#60

Problem is: Butt and/or LS overwrites this (see details in issue)
@gammaw gammaw added feature and removed bug Something isn't working labels Mar 24, 2020
@gammaw
Copy link
Member Author

gammaw commented Mar 24, 2020

See if this helps: #209

@gammaw
Copy link
Member Author

gammaw commented Apr 12, 2020

Upstream ticket for Butt entered: https://sourceforge.net/p/butt/feature-requests/27/

@gammaw gammaw removed this from the 0.3 - stability release milestone Apr 15, 2020
@gammaw
Copy link
Member Author

gammaw commented Apr 24, 2020

Todo: check update in new 0.1.20 Butt (see: https://sourceforge.net/p/butt/feature-requests/27/#f736)

@gammaw gammaw unassigned pvj Apr 24, 2020
@gammaw
Copy link
Member Author

gammaw commented May 9, 2020

Status:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants