Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit names with non-low-ASCII characters (e.g. é) prevent opening of section #8

Open
sorghumking opened this issue Feb 8, 2024 · 0 comments
Labels

Comments

@sorghumking
Copy link
Member

sorghumking commented Feb 8, 2024

Such characters in a model's description fields are escaped properly when saving section data to XML. However, name fields are not. Imitating description escaping for name fields is a quick easy fix. But that depends entirely on continued use of fields called name and description in new models.

A more robust fix would be to add a boolean constraint called e.g. escapeText to free-text fields that require escaping. Of course, that too requires awareness of the need to include that constraint in a new model/field. But it still beats hard-coded checks of field names.

@sorghumking sorghumking added the bug label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant