Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we ready for 0.1.0 release yet? #21

Closed
3 tasks done
01micko opened this issue Jun 22, 2024 · 4 comments
Closed
3 tasks done

Are we ready for 0.1.0 release yet? #21

01micko opened this issue Jun 22, 2024 · 4 comments

Comments

@01micko
Copy link
Contributor

01micko commented Jun 22, 2024

I think most 'bugs' are fixed. Of course there's always bugs!

  • are tests fixed?
  • manpage?
  • truncation?
@01micko
Copy link
Contributor Author

01micko commented Jun 22, 2024

The debian way log

labwc-menu-generator_0.1.0-1_amd64.build
 dpkg-buildpackage -rfakeroot -us -uc -ui
dpkg-buildpackage: info: source package labwc-menu-generator
dpkg-buildpackage: info: source version 0.1.0-1
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Mick Mars <[email protected]>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 debian/rules clean
dh clean
   dh_clean
 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building labwc-menu-generator using existing ./labwc-menu-generator_0.1.0.orig.tar.gz
dpkg-source: info: building labwc-menu-generator in labwc-menu-generator_0.1.0-1.debian.tar.xz
dpkg-source: info: building labwc-menu-generator in labwc-menu-generator_0.1.0-1.dsc
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
	cd obj-x86_64-linux-gnu && DEB_PYTHON_INSTALL_LAYOUT=deb LC_ALL=C.UTF-8 meson setup .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu -Dpython.bytecompile=-1
The Meson build system
Version: 1.4.1
Source dir: /home/mick/Packages/lab2/labwc-menu-generator-0.1.0
Build dir: /home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu
Build type: native build
Project name: labwc-menu-generator
Project version: 0.1.0
C compiler for the host machine: cc (gcc 13.2.0 "cc (Debian 13.2.0-25) 13.2.0")
C linker for the host machine: cc ld.bfd 2.42.50.20240618
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: YES (/usr/bin/pkg-config) 1.8.1
Run-time dependency glib-2.0 found: YES 2.80.2
Program scdoc found: YES (/usr/bin/scdoc)
Dependency glib-2.0 found: YES 2.80.2 (cached)
Build targets in project: 5

labwc-menu-generator 0.1.0

  User defined options
    buildtype         : plain
    libdir            : lib/x86_64-linux-gnu
    localstatedir     : /var
    prefix            : /usr
    sysconfdir        : /etc
    wrap_mode         : nodownload
    python.bytecompile: -1

Found ninja-1.12.1 at /usr/bin/ninja
   dh_auto_build
	cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j6 -v
[1/12] cc -It/t1000.p -It -I../t -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -MD -MQ t/t1000.p/t1000.t.c.o -MF t/t1000.p/t1000.t.c.o.d -o t/t1000.p/t1000.t.c.o -c ../t/t1000.t.c
../t/t1000.t.c: In function ‘main’:
../t/t1000.t.c:24:9: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   24 |         system(command);
      |         ^~~~~~~~~~~~~~~
[2/12] cc -It/libtest_lib.a.p -It -I../t -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ t/libtest_lib.a.p/tap.c.o -MF t/libtest_lib.a.p/tap.c.o.d -o t/libtest_lib.a.p/tap.c.o -c ../t/tap.c
[3/12] cc -It/t1001.p -It -I../t -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -MD -MQ t/t1001.p/t1001.t.c.o -MF t/t1001.p/t1001.t.c.o.d -o t/t1001.p/t1001.t.c.o -c ../t/t1001.t.c
../t/t1001.t.c: In function ‘main’:
../t/t1001.t.c:24:9: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   24 |         system(command);
      |         ^~~~~~~~~~~~~~~
[4/12] cc -Ilabwc-menu-generator.p -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ labwc-menu-generator.p/ignore.c.o -MF labwc-menu-generator.p/ignore.c.o.d -o labwc-menu-generator.p/ignore.c.o -c ../ignore.c
[5/12] cc -It/libtest_lib.a.p -It -I../t -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ t/libtest_lib.a.p/test-lib.c.o -MF t/libtest_lib.a.p/test-lib.c.o.d -o t/libtest_lib.a.p/test-lib.c.o -c ../t/test-lib.c
[6/12] rm -f t/libtest_lib.a && gcc-ar csrDT t/libtest_lib.a t/libtest_lib.a.p/tap.c.o t/libtest_lib.a.p/test-lib.c.o
[7/12] /usr/bin/meson --internal exe --capture data/labwc-menu-generator.1 --feed ../data/labwc-menu-generator.1.scd -- /usr/bin/scdoc
[8/12] cc  -o t/t1001 t/t1001.p/t1001.t.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,--start-group t/libtest_lib.a /usr/lib/x86_64-linux-gnu/libglib-2.0.so -Wl,--end-group
[9/12] cc  -o t/t1000 t/t1000.p/t1000.t.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,--start-group t/libtest_lib.a /usr/lib/x86_64-linux-gnu/libglib-2.0.so -Wl,--end-group
[10/12] cc -Ilabwc-menu-generator.p -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ labwc-menu-generator.p/main.c.o -MF labwc-menu-generator.p/main.c.o.d -o labwc-menu-generator.p/main.c.o -c ../main.c
[11/12] cc -Ilabwc-menu-generator.p -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ labwc-menu-generator.p/desktop.c.o -MF labwc-menu-generator.p/desktop.c.o.d -o labwc-menu-generator.p/desktop.c.o -c ../desktop.c
[12/12] cc  -o labwc-menu-generator labwc-menu-generator.p/main.c.o labwc-menu-generator.p/desktop.c.o labwc-menu-generator.p/ignore.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/mick/Packages/lab2/labwc-menu-generator-0.1.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 /usr/lib/x86_64-linux-gnu/libglib-2.0.so
   dh_auto_test
	cd obj-x86_64-linux-gnu && DEB_PYTHON_INSTALL_LAYOUT=deb LC_ALL=C.UTF-8 MESON_TESTTHREADS=6 meson test
ninja: Entering directory `/home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu'
ninja: no work to do.
1/2 t1000 OK              0.01s   1 subtests passed
2/2 t1001 OK              0.01s   1 subtests passed

Ok:                 2   
Expected Fail:      0   
Fail:               0   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0   

Full log written to /home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu/meson-logs/testlog.txt
   create-stamp debian/debhelper-build-stamp
   dh_prep
   debian/rules override_dh_auto_install
make[1]: Entering directory '/home/mick/Packages/lab2/labwc-menu-generator-0.1.0'
dh_auto_configure --buildsystem=meson
	cd obj-x86_64-linux-gnu && DEB_PYTHON_INSTALL_LAYOUT=deb LC_ALL=C.UTF-8 meson setup .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu -Dpython.bytecompile=-1
Directory already configured.

Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
Run "meson setup --reconfigure to force Meson to regenerate.

If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.
meson compile -C obj-x86_64-linux-gnu/
ninja: Entering directory `/home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu'
ninja: no work to do.
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu
meson install -C obj-x86_64-linux-gnu/ --destdir=$(pwd)/debian/labwc-menu-generator
ninja: Entering directory `/home/mick/Packages/lab2/labwc-menu-generator-0.1.0/obj-x86_64-linux-gnu'
ninja: no work to do.
Installing labwc-menu-generator to /home/mick/Packages/lab2/labwc-menu-generator-0.1.0/debian/labwc-menu-generator/usr/bin
Installing data/labwc-menu-generator.1 to /home/mick/Packages/lab2/labwc-menu-generator-0.1.0/debian/labwc-menu-generator/usr/share/man/man1
make[1]: Leaving directory '/home/mick/Packages/lab2/labwc-menu-generator-0.1.0'
   dh_installdocs
   dh_installchangelogs
   dh_installman
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
   dh_fixperms
   dh_missing
   dh_dwz -a
   dh_strip -a
   dh_makeshlibs -a
   dh_shlibdeps -a
   dh_installdeb
   dh_gencontrol
   dh_md5sums
   dh_builddeb
dpkg-deb: building package 'labwc-menu-generator' in '../labwc-menu-generator_0.1.0-1_amd64.deb'.
dpkg-deb: building package 'labwc-menu-generator-dbgsym' in '../labwc-menu-generator-dbgsym_0.1.0-1_amd64.deb'.
 dpkg-genbuildinfo -O../labwc-menu-generator_0.1.0-1_amd64.buildinfo
 dpkg-genchanges -O../labwc-menu-generator_0.1.0-1_amd64.changes
dpkg-genchanges: info: including full source code in upload
 dpkg-source --after-build .
dpkg-buildpackage: info: full upload (original source is included)
Now running lintian labwc-menu-generator_0.1.0-1_amd64.changes ...
Finished running lintian.

Not much to worry about there.

@johanmalm
Copy link
Collaborator

We ought to add a --terminal-prefix (or similar) option to specify what terminal command to use with Terminal=true entries. IIRC I already have a patch locally on my machine at home, so can create a PR for that.

Other than that, I'm happy to release 0.1.0.

@01micko btw - I changed the tests so that:

  1. We now only use the meson infrastructure (Makefiles deleted)
  2. We run the TAP tests directly under meson without any sharness help (the shell test-library that originated in git)
  3. The unit tests are included in the .github workflow

I noticed that you'd written another unit-test, so should have notified you of all that. Apologies.
It was you working on labwc-menu-generator that inspired me to sort out the tests + CI 😄

@01micko
Copy link
Contributor Author

01micko commented Jun 22, 2024

We ought to add a --terminal-prefix (or similar) option to specify what terminal command to use with Terminal=true entries. IIRC I already have a patch locally on my machine at home, so can create a PR for that.

Other than that, I'm happy to release 0.1.0.

Nice. You do that and I'll update the man page if you like.

@01micko btw - I changed the tests so that:

  1. We now only use the meson infrastructure (Makefiles deleted)
  2. We run the TAP tests directly under meson without any sharness help (the shell test-library that originated in git)
  3. The unit tests are included in the .github workflow

Excellent job! Certainly makes sens to use meson only.

I noticed that you'd written another unit-test, so should have notified you of all that. Apologies. It was you working on labwc-menu-generator that inspired me to sort out the tests + CI 😄

Thanks!

@johanmalm
Copy link
Collaborator

https://github.com/labwc/labwc-menu-generator/releases/tag/0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants