Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adwaita-papyrus-dark: new theme #25

Merged
merged 17 commits into from
Sep 28, 2024
Merged

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Sep 28, 2024

Based on the work of others, this is my interpretation of a a Labwc SSD appearance. As the readme states, I tried to be as close as possible to GTK3/4 CSD applications with the Papirus icon theme to have a consistent SSD/CSD appearance. I'm happy with how it looks, so I thought I share.

MPV screenshot with SSD:

Screenshot

To compare, this is how Gnome Calculator with CSD appears:

Screenshot

PS: I recommend to squash. Also I hope that the screenshot in the readme works like in the fork repo (https://github.com/jp7677/labwc-artwork/tree/adwaita-papyrus-dark/themes/Adwaita-Papirus-dark).

@01micko
Copy link
Contributor

01micko commented Sep 28, 2024

Nice! I'm going to try now.

@01micko
Copy link
Contributor

01micko commented Sep 28, 2024

Looks good.

I used galculator because it has an xpm icon to get a look at the menu icon in play.

galculator

Seems to be inconsistencies with menu and desk. Menu isn't likely to matter as many users would use window icons .

@johanmalm ?

@jp7677
Copy link
Contributor Author

jp7677 commented Sep 28, 2024

If you really want to use all icons, a titlebar configuration/order like this looks probably better:

<titlebar layout="desk:menu,iconify,shade,max,close" showTitle="yes" />

I've indeed omitted icon in my configuration, since GTK/Adwaita also don't use a window icon.

@01micko
Copy link
Contributor

01micko commented Sep 28, 2024

I get your point. I can see the consistency with the CSD.

LGTM

@01micko 01micko merged commit c51c8ee into labwc:main Sep 28, 2024
@01micko
Copy link
Contributor

01micko commented Sep 28, 2024

Screenshot survived the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants