Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Change operations mean, std, substract, div in the StandardScaler to equistore operations #19

Closed
agoscinski opened this issue Feb 23, 2023 · 1 comment
Closed

Change operations mean, std, substract, div in the StandardScaler to equistore operations #19

agoscinski opened this issue Feb 23, 2023 · 1 comment

Comments

@agoscinski
Copy link
Collaborator

agoscinski commented Feb 23, 2023 •
edited
Loading

unrelated to this PR, but why is the StandardScaler not implemented in terms of equistore operations? It looks like it is re-doing what should be equistore.mean, equistore.std, equistore.substract, equistore.div. Is something missing in the operations?

Originally posted by @Luthaf in #15 (comment)
@Luthaf
Copy link
Collaborator

Luthaf commented Feb 23, 2023

Duplicate of #18 =)

@Luthaf Luthaf closed this as completed Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agoscinski @Luthaf