Align auto-convert feature between web gui and cli #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been auto-converting images for the web gui, while prompting the user from the CLI composer. Given that the CLI prompt is causing issues with the new "non-interactive" cli composer, I believe it's reasonable to avoid this complexity by doing auto-convertion on the command line aswell. We could consider adding a config options to let the user control this behavior in the future. But until then, let's keep it simple. Resolves #431
xylo04
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been auto-converting images for the web gui, while prompting the user from the CLI composer. Given that the CLI prompt is causing issues with the new "non-interactive" cli composer, I believe it's reasonable to avoid this complexity by doing auto-convertion on the command line aswell.
We could consider adding a config options to let the user control this behavior in the future. But until then, let's keep it simple.
Resolves #431