Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extensions fetcher error handler #2235

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Improve extensions fetcher error handler #2235

merged 1 commit into from
Nov 6, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Nov 4, 2024

Description

Changes proposed in this pull request:

  • print extensions warning to user when he pass the --show-extensions-error flag
  • fix the --kubeconfig flag (handler value in format: --kubeconfig=<value>

Related issue(s)

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Nov 4, 2024
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@pPrecel pPrecel force-pushed the improve-extension-logging branch 2 times, most recently from c2e56a7 to e543b6f Compare November 4, 2024 10:40
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2024
@pPrecel pPrecel marked this pull request as ready for review November 5, 2024 10:26
@pPrecel pPrecel requested a review from a team as a code owner November 5, 2024 10:26
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 6, 2024
@pPrecel pPrecel merged commit f832f58 into kyma-project:main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

Assignees

@anoipm anoipm

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @anoipm @kyma-bot