Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to access command #2203

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Add tests to access command #2203

merged 4 commits into from
Aug 9, 2024

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Aug 7, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Move access command parts to another package
  • add tests

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@kyma-bot
Copy link

kyma-bot commented Aug 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2024
@halamix2 halamix2 changed the title Move access command parts to another package Add tests to access command Aug 7, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2024
@halamix2 halamix2 marked this pull request as ready for review August 8, 2024 09:38
@halamix2 halamix2 requested a review from a team as a code owner August 8, 2024 09:38
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot merged commit f61f4ed into kyma-project:main Aug 9, 2024
4 checks passed
@halamix2 halamix2 deleted the access-rework branch August 9, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

Assignees

@pPrecel pPrecel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @kyma-bot @pPrecel