Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix finding latest version of module in command modules catalog #2171

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

anoipm
Copy link
Contributor

@anoipm anoipm commented Jul 3, 2024

Description

Changes proposed in this pull request:

  • fix finding latest version of module in command modules catalog

Related issue(s)
See also #2168

@anoipm anoipm added kind/bug Categorizes issue or PR as related to a bug. area/cli Related to all activities around CLI labels Jul 3, 2024
@anoipm anoipm requested a review from a team as a code owner July 3, 2024 08:54
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2024
@anoipm anoipm added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 3, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jul 3, 2024
@anoipm anoipm force-pushed the last-module-version branch 2 times, most recently from 0094d49 to aed3320 Compare July 3, 2024 09:12
@anoipm anoipm removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@Cortey Cortey self-assigned this Jul 3, 2024
go.mod Outdated
@@ -6,6 +6,7 @@ require (
github.com/gboddin/go-www-authenticate-parser v0.0.0-20230926203616-ec0b649bb077
github.com/google/go-containerregistry v0.19.2
github.com/olekukonko/tablewriter v0.0.5
github.com/rogpeppe/go-internal v1.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use this package and not golang.org/x/mod/semver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 4, 2024
@kyma-bot kyma-bot merged commit 2535199 into kyma-project:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants